New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752402 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651762



Sign in to add a comment

innerHTML/outerHTML serializer drops attribute's prefix

Project Member Reported by tkent@chromium.org, Aug 4 2017

Issue description

Chrome Version: 62 canary
OS: All but iOS

What steps will reproduce the problem?
(1) Open http://w3c-test.org/html/syntax/serializing-html-fragments/serializing.html
(2) See "innerHTML Attribute in non-standard namespace" and "outerHTML Attribute in non-standard namespace"

What is the expected result?
They pass.

What happens instead?
They fail because |def| attribute has no |abc| prefix.


Please use labels and text to provide additional information.
Firefox and Edge work fine. Safari has the same issue.

Probably a bug in MarkupFormatter::AppendAttribute(). It drops attribute prefixes if it's in HTML document.


 

Comment 1 by tkent@chromium.org, Aug 4 2017

Blocking: 651762

Comment 2 by tkent@chromium.org, Aug 4 2017

Description: Show this description
Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e06d40f52c4a69790bfb31deaea6595b8443fd2c

commit e06d40f52c4a69790bfb31deaea6595b8443fd2c
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Tue Aug 08 07:00:05 2017

InnerHTML/outerHTML serializer should include attribute's prefix

Changing MarkupFormatter::AppendAttribute() to include
attribute prefixes if it is in HTML Document.

Bug:  752402 
Change-Id: Iaf1304e82e5caf95c19a7f73181afd9f8fa72c1f
Reviewed-on: https://chromium-review.googlesource.com/603210
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#492560}
[modify] https://crrev.com/e06d40f52c4a69790bfb31deaea6595b8443fd2c/third_party/WebKit/LayoutTests/external/wpt/html/syntax/serializing-html-fragments/serializing-expected.txt
[modify] https://crrev.com/e06d40f52c4a69790bfb31deaea6595b8443fd2c/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp

Status: Fixed (was: Started)

Comment 7 by tkent@chromium.org, Aug 8 2017

Labels: M-62

Sign in to add a comment