New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752395 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

In the sign-in screen of an already managed device, the Enterprise enrollment option is redundant

Project Member Reported by jingwee@chromium.org, Aug 4 2017

Issue description

Chrome Version: M61.0.3163.30 dev Banjo
OS: ChromeOS 9765.16.0

What steps will reproduce the problem?
(1) Enrolled device
(2) At the user sign-in screen, click on "More options" menu.

What is the expected result?
When a device is already managed by Enterprise, it is not applicable to show the enrollment option.

What happens instead?
The "More options" menu contains a "Enterprise enrollment" selection.  Obviously, select the options has no effect since the device is already enrolled.
 
Screenshot 2017-08-03 at 9.48.49 PM.png
638 KB View Download
Owner: alemate@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/755b8a3608e6126c19ce0003f41ef4d3f524e0a0

commit 755b8a3608e6126c19ce0003f41ef4d3f524e0a0
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Aug 12 02:54:46 2017

ChromeOS Gaia: show Enterprise Enrollment option for unenrolled device only.

We should show Enterprise Enrollment option for unenrolled device only.

Bug:  752395 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d7063379008aaf5073e20c7ff5dd88ce55d23c3
Reviewed-on: https://chromium-review.googlesource.com/602744
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493943}
[modify] https://crrev.com/755b8a3608e6126c19ce0003f41ef4d3f524e0a0/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/755b8a3608e6126c19ce0003f41ef4d3f524e0a0/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Labels: M-61 Merge-Request-61
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 13 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge for M61 Chrome OS.
Approving merge for M61 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fedd5bbcbd0fc4fafe6af52e38bbae8d88419833

commit fedd5bbcbd0fc4fafe6af52e38bbae8d88419833
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 16 22:45:39 2017

ChromeOS Gaia: show Enterprise Enrollment option for unenrolled device only.

We should show Enterprise Enrollment option for unenrolled device only.

TBR=alemate@chromium.org

(cherry picked from commit 755b8a3608e6126c19ce0003f41ef4d3f524e0a0)

Bug:  752395 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d7063379008aaf5073e20c7ff5dd88ce55d23c3
Reviewed-on: https://chromium-review.googlesource.com/602744
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493943}
Reviewed-on: https://chromium-review.googlesource.com/617658
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#612}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/fedd5bbcbd0fc4fafe6af52e38bbae8d88419833/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/fedd5bbcbd0fc4fafe6af52e38bbae8d88419833/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Status: Verified (was: Fixed)
As verified in M61.0.3163.53:9765.32.0 dev reks/daisy/candy, this issue has been fixed. The "Enterprise enrollment" option is only shown before the device was enrolled and before signed in as user for the first time.

Sign in to add a comment