New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752390 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Most visited sites disappear from new tab page after close chrome.

Reported by swpwithc...@gmail.com, Aug 4 2017

Issue description

Steps to reproduce the problem:
1. Launch chrome.
2. go to any web page (ex. m.naver.com)
3. check NTP until the item is added.
4. after the item is added, close chrome application.
5. re launch chrome
6. check NTP.

What is the expected behavior?
The item will be remained in NTP.

What went wrong?
the item is disappear after re-launch chrome.

Did this work before? No 

Chrome version: 59.0.3071.104  Channel: stable
OS Version: 60.3112.78
Flash Version:
 
Dears.
Please check this attachment.
NTP.mp4
8.8 MB View Download
Cc: tedc...@chromium.org
Components: UI>Browser>NewTabPage
Labels: Needs-Feedback
Hello

Thanks for reporting the issue. However, we were unable to repro this issue on Samsung Galaxy S6 Edge/NRD90M on Chrome: 60.3112.78. Can you please provide additional details like device name, model, frequency of the issue. Please provide  a bugreport, if possible.

To get bugreport:
Android Settings > About Phone > Tap Build number 7 times, go back one screen, Developer options should be right above About phone.
Once you have enabled developer options,  to take a bug report,go to Android Settings -> Developer Options ->Enable USB Debugging and then tap on Take bug report

Owner: bauerb@chromium.org

Hello

I think this issue can reproduced in low-end device.
I can reproduce in Galaxy On 5
Model no: SM-G5220
frequency of the issue: sometimes.

I'll share the device's bug report.
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 7 2017

Cc: ppolise...@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "ppolisetty@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sorry. 
The Model number is: SM-G5520.
not 5220.
Hello.
It can be reproduced in Nexus 5.
This is bugreport and reproduce video.
Please check this attachments.
bugreport-2017-08-07-14-26-00.zip
1.3 MB Download
bugreport-2017-08-07-14-26-00.png
151 KB View Download
NTP2.mp4
8.8 MB View Download
Nexus 5
Android Os version: 6.0.1
Chrome version: 59.0.3071.125

Comment 9 by fi...@chromium.org, Aug 7 2017

Cc: mastiz@chromium.org
+mastiz

There are two more things which are weird:

1. The icon has the offline checkmark
2. On the second NTP impression we no longer show a colored scrabble tile


Cc: -mastiz@chromium.org bauerb@chromium.org
Owner: mastiz@chromium.org
Status: Assigned (was: Unconfirmed)
Could you post the "variations" section from chrome://version, and the contents of chrome://ntp-tiles-internals/ (the latter when the icon is shown and when it isn't shown)? Thanks!
Hello. 
This is variations from chrome://version and ntp-tiles-internals when the icon is not shown.
Screenshot_chrome_variations.png
402 KB View Download
Screenshot_20170808-111746.png
106 KB View Download
Labels: -Pri-2 Pri-3
Thanks for reporting! I was able to reproduce this behavior on dev and trunk.

I believe it can reproduced if you close Chrome within 10 seconds of visiting the page, which is arguably not a normal use. Hence adjusting priority to P3.

A few more insights:
1. The History UI doesn't display the page visit as if naver.com was never typed).
2. If, prior to following the described steps, another URL is visited (leading to an additional tile in the NTP), this other tile never goes away from the NTP, and neither does the history entry.

This what I believe is happening:
1. When you visit the page, it gets processed by both HistoryBackend (VisitSegmentDatabase) and TopSitesDatabase.

2. TopSitesDatabase commits the transaction immediately (hence the update gets persisted).

3. HistoryBackend (the authoritative source for TopSites) defers the commit by 10 seconds (for performance reasons).

4. If Chrome gets killed during that time, HistoryBackend never commits and hence the data is lost.

5. During startup, TopSites are first read from TopSitesImpl (TopSitesImpl::OnGotMostVisitedThumbnails()), and TopSitesImpl::MoveStateToLoaded() already reports 2 tiles being available (one of which is not backed up with data in the history database).

6. The history backend eventually replies with 1 tile, i.e. HistoryBackend::QueryMostVisitedURLs() which overrides the previous list.


I'm wondering if the transactions to the TopSitesDatabase shouldn't be batched together with HistoryBackend transactions.
Labels: zine-triaged
Status: WontFix (was: Assigned)
I'm closing this bug since it's very unlikely that we can fix it, and the severity is low.

Thanks for reporting!

Sign in to add a comment