New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752383 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Shelf is not transparent when fullscreen app list is opened in tablet mode

Project Member Reported by minch@chromium.org, Aug 4 2017

Issue description

Bottom shelf should be transparent if fullscreen app list is opened.
This is true in laptop mode, but shelf area is still black if in tablet mode.
 
Screenshot from 2017-08-03 20:41:04.png
172 KB View Download

Comment 1 by minch@chromium.org, Aug 8 2017

Status: Started (was: Assigned)
Cc: -mccanny@chromium.org -newcomer@chromium.org sgabr...@chromium.org shibasheikh@chromium.org
I just noticed that we aren't tracking this bug in the work tracker. Is this a mistakenly hidden P0 for V1?
Cc: mccanny@chromium.org newcomer@chromium.org
(didn't mean to remove mccanny or myself from cc)

Comment 4 by minch@chromium.org, Aug 14 2017

Labels: Merge-Request-61
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 14 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55709dd24edad7c026e0ba7ecdb6a9b4b196894c

commit 55709dd24edad7c026e0ba7ecdb6a9b4b196894c
Author: MinChen <minch@chromium.org>
Date: Tue Aug 15 17:48:03 2017

Disable backdrop if fullscreen app list is opened in tablet mode.

If fullscreen app list is opened, the shelf should change to be transparent.
But since there is a fullscreen backdrop window in tablet mode. The shelf area
is still black after app list is opened.

Change:
Add OnAppListVisibilityChanged(*) in BackdropController. Hide backdrop if app list
is opened, update it if app list is dismissed.

Bug:  752383 
Change-Id: Ic1be66eb5cb9b0a4d126d8e8d78aa2f229b824b8
Reviewed-on: https://chromium-review.googlesource.com/606706
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494437}
[modify] https://crrev.com/55709dd24edad7c026e0ba7ecdb6a9b4b196894c/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/55709dd24edad7c026e0ba7ecdb6a9b4b196894c/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/55709dd24edad7c026e0ba7ecdb6a9b4b196894c/ash/wm/workspace/workspace_layout_manager_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/528643eac1afd68c58116742f22c20794f04dba9

commit 528643eac1afd68c58116742f22c20794f04dba9
Author: MinChen <minch@chromium.org>
Date: Tue Aug 15 21:24:19 2017

Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop.

Bug:  752383 
Change-Id: I990cbed13618e5857dc5927b787d9468d4a91626
Reviewed-on: https://chromium-review.googlesource.com/615812
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494552}
[modify] https://crrev.com/528643eac1afd68c58116742f22c20794f04dba9/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/528643eac1afd68c58116742f22c20794f04dba9/ash/wm/workspace/workspace_layout_manager_unittest.cc

Project Member

Comment 9 by sheriffbot@chromium.org, Aug 18 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 21 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 21 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3

commit cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3
Author: Vadim Tryshev <vadimt@google.com>
Date: Mon Aug 21 21:27:34 2017

Disable backdrop if fullscreen app list is opened in tablet mode.

If fullscreen app list is opened, the shelf should change to be transparent.
But since there is a fullscreen backdrop window in tablet mode. The shelf area
is still black after app list is opened.

Change:
Add OnAppListVisibilityChanged(*) in BackdropController. Hide backdrop if app list
is opened, update it if app list is dismissed.

TBR=minch@chromium.org

(cherry picked from commit 55709dd24edad7c026e0ba7ecdb6a9b4b196894c)

Bug:  752383 
Change-Id: Ic1be66eb5cb9b0a4d126d8e8d78aa2f229b824b8
Reviewed-on: https://chromium-review.googlesource.com/606706
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494437}
Reviewed-on: https://chromium-review.googlesource.com/624726
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#721}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3/ash/wm/workspace/workspace_layout_manager_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b5a53b8d7abf736b23a74801ce39f84652b3fb

commit c5b5a53b8d7abf736b23a74801ce39f84652b3fb
Author: Vadim Tryshev <vadimt@google.com>
Date: Mon Aug 21 21:34:38 2017

Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop.

TBR=minch@chromium.org

(cherry picked from commit 528643eac1afd68c58116742f22c20794f04dba9)

Bug:  752383 
Change-Id: I990cbed13618e5857dc5927b787d9468d4a91626
Reviewed-on: https://chromium-review.googlesource.com/615812
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494552}
Reviewed-on: https://chromium-review.googlesource.com/624799
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#727}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c5b5a53b8d7abf736b23a74801ce39f84652b3fb/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/c5b5a53b8d7abf736b23a74801ce39f84652b3fb/ash/wm/workspace/workspace_layout_manager_unittest.cc

Comment 13 by minch@chromium.org, Aug 21 2017

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cabb5d9c82c12cf02fc667a0d37ca83e6392df8

commit 7cabb5d9c82c12cf02fc667a0d37ca83e6392df8
Author: Vladislav Kaznacheev <kaznacheev@chromium.org>
Date: Mon Aug 21 23:32:23 2017

Revert "Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop."

This reverts commit c5b5a53b8d7abf736b23a74801ce39f84652b3fb.

Reason for revert: 
This is required to revert cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3 which is breaking most of ash_unittests

Original change's description:
> Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop.
> 
> TBR=minch@chromium.org
> 
> (cherry picked from commit 528643eac1afd68c58116742f22c20794f04dba9)
> 
> Bug:  752383 
> Change-Id: I990cbed13618e5857dc5927b787d9468d4a91626
> Reviewed-on: https://chromium-review.googlesource.com/615812
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: min c <minch@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#494552}
> Reviewed-on: https://chromium-review.googlesource.com/624799
> Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3163@{#727}
> Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

TBR=flackr@chromium.org,vadimt@chromium.org,minch@chromium.org

Change-Id: I219540f311183e077809ca9547b5fdd63477bbe7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  752383 
Reviewed-on: https://chromium-review.googlesource.com/624703
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#741}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/7cabb5d9c82c12cf02fc667a0d37ca83e6392df8/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/7cabb5d9c82c12cf02fc667a0d37ca83e6392df8/ash/wm/workspace/workspace_layout_manager_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d82eee4113b8d0fbf110f3fb39eb28de05ff3307

commit d82eee4113b8d0fbf110f3fb39eb28de05ff3307
Author: xdai <xdai@chromium.org>
Date: Tue Aug 22 20:08:00 2017

[Merge to M61]Disable backdrop if fullscreen app list is opened in tablet mode.

Merge this CL to M61 on behalf of minch@.

If fullscreen app list is opened, the shelf should change to be transparent.
But since there is a fullscreen backdrop window in tablet mode. The shelf area
is still black after app list is opened.

Change:
Add OnAppListVisibilityChanged(*) in BackdropController. Hide backdrop if app list
is opened, update it if app list is dismissed.

TBR=minch@chromium.org, flackr@chromium.org, newcomer@chromium.org
(cherry picked from commit 55709dd24edad7c026e0ba7ecdb6a9b4b196894c)

Bug:  752383 
Change-Id: Ice03059ed38cef86bfe1ba83296b08d4236ec49e
Reviewed-on: https://chromium-review.googlesource.com/606706
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494437}
Reviewed-on: https://chromium-review.googlesource.com/627108
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#775}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d82eee4113b8d0fbf110f3fb39eb28de05ff3307/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/d82eee4113b8d0fbf110f3fb39eb28de05ff3307/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/d82eee4113b8d0fbf110f3fb39eb28de05ff3307/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/d82eee4113b8d0fbf110f3fb39eb28de05ff3307/ash/wm/workspace/workspace_layout_manager_unittest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36009118c3f58e84cbf49e81380d46121e2304e4

commit 36009118c3f58e84cbf49e81380d46121e2304e4
Author: xdai <xdai@chromium.org>
Date: Tue Aug 22 20:28:32 2017

[Merge to M61]Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop.

Merge this CL on behalf of minch@.

TBR=minch@chromium.org, flackr@chromium.org
(cherry picked from commit 528643eac1afd68c58116742f22c20794f04dba9)

Bug:  752383 
Change-Id: I372b966dfb0728566b4f9e58faa3cb281efb663e
Reviewed-on: https://chromium-review.googlesource.com/615812
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494552}
Reviewed-on: https://chromium-review.googlesource.com/627109
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#778}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/36009118c3f58e84cbf49e81380d46121e2304e4/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/36009118c3f58e84cbf49e81380d46121e2304e4/ash/wm/workspace/workspace_layout_manager_unittest.cc

Comment 17 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment