The web pages loaded with voice search is not displayed as Top sites/ in most visited tiles |
|||||||||
Issue descriptionApp Version:61.0.3163.30 iOS Version: 9.3.5,10.3.3, 11.0 beta 4 Device: iPhone and iPad URL: bbc.com or any other webpage URL Steps to reproduce: 1. Fresh install and launch chrome 2. Tap on the GLIF icon in NTP 3. Speak any webpage url 4. Wait for the webpage to load and open NTP Observed results: The webpages that are loaded from voice search is not displayed in the most visited tiles Note: web page will display in most visited tile if it is loaded using device keyboard Expected results: The webpages loaded using voice search should display in the most visited tiles Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: No Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Yes on M60 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M61 Link to video/image: iOS behavior: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8cjVtei1JVFJYclE/view?usp=sharing Android behavior: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8R05yTmJDZ2d5Qjg/view?usp=sharing
,
Aug 4 2017
I think this is related to voice search more than NTP. Kurt: do you know what we are using as transition type?
,
Aug 7 2017
VoiceSearch queries are handled by WebToolbarController, and have the transition type of LINK | FROM_ADDRESS_BAR. I'm not sure where the logic lives for adding pages to the most visited list, but it may be that LINK navigations do not get added. Assigning back to Gauthier for most visited implementation. https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm?q=web_toolbar_controller.mm&sq=package:chromium&dr&l=1850
,
Aug 8 2017
treib@: do you know if having a transition type LINK would prevent a page from being displayed in the most visited?
,
Aug 8 2017
Yes, only TYPED and AUTO_BOOKMARK transitions will lead to a site being considered for NTP tiles. I think it might make sense to assign TYPED to voice searches, the same as if the query had been typed into the Omnibox. WDYT? (If we decide to do this, we should also consider it for other platforms. I don't know what Android currently does.)
,
Aug 8 2017
+mardini for opinion. Yes it makes sense to have the TYPED transition type for voice search. From the bug description, Android considers the voice search transition for most visited.
,
Aug 8 2017
I agree. Voice Search should be TYPED (pun unintended).
,
Aug 8 2017
I don't know if we'd want it to be typed 100% of the time though. If you do a voice search for a phrase that isn't a URL, it will perform a google search for that phrase, and I don't know if we want the search results page for that search query to show up in the most visited tiles. I do agree that voice searches like "BBC dot com" are equivalent to the user typing out the URL, and therefore should be treated as TYPED.
,
Aug 9 2017
,
Aug 10 2017
I think we should do as the omnibox is doing: if you type something it will perform a search or go to the address. I guess we insert the right transition type somewhere. Can't we do something similar for voice search?
,
Aug 16 2017
,
Sep 27 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by olivierrobin@chromium.org
, Aug 4 2017Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)