New issue
Advanced search Search tips

Issue 752364 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Generalize test runner script to run other non-test executables

Project Member Reported by kmarshall@chromium.org, Aug 4 2017

Issue description

To assist in the development of executables other than test binaries, e.g. "content_shell", we should extend the Python scripts to support building and deploying Fuchsia images for non-test GN executables.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/143e53fb43b6dfbee260273daaa4b033c3edf1ec

commit 143e53fb43b6dfbee260273daaa4b033c3edf1ec
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 10 20:33:25 2017

Fuchsia: modify scripts to run non-test executables

Fuchsia: modify scripts to run non-test executables
* Move most test runner functionality to "runner_common.py", with
  the exception of gtest-specific logic.
* Move the test-specific "main()" portions into "test_runner.py".
* Add "exe_runner.py", a very thin wrapper around the test_common
  functionality.
* Use stripped executables for building the bootfs file, which results
  in a substantially smaller file size (10x difference!)
  It's necessary for running larger executables like "headless_shell",
  which are enormous when unstripped, resulting in long mkbootfs times
  and higher RAM requirements for in-memory tmpfs disks. The unstripped
  executable remains intact alongside the stripped executable, for
  backtrace symbolization.
* Add a GN template "fuchsia_executable_runner", which generates
  executable runner scripts on non-test targets.


Bug:  746674 , 752364 
Change-Id: Ia39c3d7fdf9bb574049f0112df84951c2e048f41
Reviewed-on: https://chromium-review.googlesource.com/602410
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493524}
[modify] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/config/fuchsia/rules.gni
[rename] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/create_runner_script.py
[add] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/exe_runner.py
[add] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/runner_common.py
[modify] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/test_runner.py
[modify] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/headless/BUILD.gn

Status: Verified (was: Assigned)

Sign in to add a comment