Issue metadata
Sign in to add a comment
|
Search input field has unspecified "Search" placeholder text |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3175.0 canary OS: macOS 10.12.5 What steps will reproduce the problem? (1) Open the following URL: data:text/html;charset=utf-8,<input type=search> What is the expected result? An empty text field should be shown. What happens instead? A text field with gray "Search" is shown. Please use labels and text to provide additional information. Probably, SDK update is the culprit.
,
Aug 10 2017
Curiouser and curiouser; it does seem likely to be a change in the underlying OS X control's behavior. The "Search" string in question isn't actually the HTML5 placeholder text (if you set a |placeholder| attribute on the control, it shows on top of the default "Search" background text in a slightly darker color with a baseline a few pixels above.) Not repro in 61.3163.
,
Aug 10 2017
It looks like https://codereview.chromium.org/586413002 was the change that suppressed the "native" placeholder text when this bug first arose in Issue 394714 . In 10.11, a change was made in this area: https://developer.apple.com/library/content/releasenotes/AppKit/RN-AppKitOlderNotes/index.html#10_11SearchField Mozilla code contains the following remark: // When using the 10.11 SDK, the default string will be shown if we don't // set the placeholder string. [cell setPlaceholderString:@""];
,
Aug 10 2017
,
Aug 14 2017
This also still shows if a placeholder is specified in the html. reproducible in 62.0.3185.0 (Official Build) canary (64-bit) not reproducible in 60.0.3112.90 (Official Build) (64-bit) see https://codepen.io/anon/pen/jLGLyb for a reproducible case
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e11d873e69b78405c93cd4382e5c52338518356 commit 8e11d873e69b78405c93cd4382e5c52338518356 Author: Eric Lawrence <elawrence@chromium.org> Date: Fri Aug 18 14:56:17 2017 Suppress native placeholder text on MacOS Input Type=Search The OS X 10.11 SDK introduced a change whereby the "Search" placeholder text is no longer suppressed by setting setCenteredLook to NO on the NSSearchFieldCell control. Instead, we now explicitly invoke |setPlaceholderString| on the control. Bug: 752362 Change-Id: I0da791fa3510d682731c5d64971ac669a7608d5a Reviewed-on: https://chromium-review.googlesource.com/610501 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Eric Lawrence <elawrence@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#495549} [modify] https://crrev.com/8e11d873e69b78405c93cd4382e5c52338518356/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
,
Aug 21 2017
IF there is no pending work, can we tag as fixed?
,
Aug 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Aug 10 2017