https://cs.chromium.org/chromium/src/chrome/browser/chromeos/first_run/first_run.cc?rcl=50375834ebfaabecf22c235d70f9eaf796b2631d&l=77 seems to return here. We can change the prefs to not syncable

Will confirm intended behavior with UI Review on Tuesday.

Let's change the pref to not syncable so that it appears whenever a user signs onto a new device for the first time.

Re#6: Sounds good. Proposed CL here: https://chromium-review.googlesource.com/c/602768

Thanks, can we also disable welcome app entirely for Enrolled devices so cart-model users don't see it every time?

Filed crbug/753566 to track issue in #8. CL in #7 is good to go!

Before this can go live, we *must* suppress the welcome screen for managed users. I bumped  bug 753566  to P1 and marked it as a stable blocker.

Re#12: Should I hold the CL in #7 until  bug 753566  is fixed?

Looks like crbug/753566 was fixed with https://chromium-review.googlesource.com/c/612346

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00eaa5ad8ea7d3700c62999579d70284c3827caf

commit 00eaa5ad8ea7d3700c62999579d70284c3827caf
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Aug 14 17:16:13 2017

Change the prefs to non-syncable for welcome app

Welcome app should be launched at the end of OOBE user flow for
all the devices. Right now the prefs that controls this behaviour
is syncable across devices, meaning welcome app will be launched only on
the first device this user signs into, which is undesired behaviour.

BUG= 752361 

Change-Id: Iab5795b568cac881cb3db498962fdb1917b038ff
Reviewed-on: https://chromium-review.googlesource.com/602768
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494083}
[modify] https://crrev.com/00eaa5ad8ea7d3700c62999579d70284c3827caf/chrome/browser/chromeos/first_run/first_run.cc

Approving merge to M61 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c64daccb74f64e867d3c3fe9f1c12a9aeb1081

commit 88c64daccb74f64e867d3c3fe9f1c12a9aeb1081
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Aug 14 18:51:35 2017

[Merge to M61]Change the prefs to non-syncable for welcome app

Welcome app should be launched at the end of OOBE user flow for
all the devices. Right now the prefs that controls this behaviour
is syncable across devices, meaning welcome app will be launched only on
the first device this user signs into, which is undesired behaviour.

TBR=alemate@chromium.org
BUG= 752361 

(cherry picked from commit 00eaa5ad8ea7d3700c62999579d70284c3827caf)

Change-Id: Iab5795b568cac881cb3db498962fdb1917b038ff
Reviewed-on: https://chromium-review.googlesource.com/602768
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494083}
Reviewed-on: https://chromium-review.googlesource.com/614131
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#544}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/88c64daccb74f64e867d3c3fe9f1c12a9aeb1081/chrome/browser/chromeos/first_run/first_run.cc

xiaoyinh@ What is the expected behavior if I delete my user account from the device and add it again on the same device? Should the Welcome app show up for this user?

I see the above behavior on latest M61 9765.31.0, 61.0.3163.51. Welcome app shows up every time I delete and add the same user account.

Re#19: The user preference(which tracks if welcome app is shown before) is changed to non-syncable. This means every time a new user signs in, this preference is reset to false('never shown'). we don't know whether this user has signed into this device before.  

To clarify #20, every time a new user is added to a device (even if they were added before and removed), there "local" preferences will be recreated; hence this preference will not be set, making us believe that the user is a new user.

We 'can' change this (I presume by storing in local state which users have signed in before, if we don't already) but I am not sure if it is a situation we care too much about.

Bug clean-up - Should this be marked as Fixed?