Put back ash::Shell::GetActiveUserPrefService() |
||||||
Issue descriptionI removed it in https://chromium-review.googlesource.com/c/590356 but it turns out to be useful for one-shot lookups of prefs (for example, when spawning a menu) where you don't need to observe the pref for changes. I have a CL that needs this behavior, so add it back.
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d51c918ac7eef16ba99e0798cb0dd51a50420b9 commit 6d51c918ac7eef16ba99e0798cb0dd51a50420b9 Author: James Cook <jamescook@chromium.org> Date: Fri Aug 04 01:31:00 2017 cros: Restore ash::Shell::GetActiveUserPrefService I removed it in https://chromium-review.googlesource.com/c/590356 but I need it in a new CL. Also, don't delete the underlying PrefService when switching users under mash. I now think it's better for the PrefService to be transiently stale than to be null during the mojo service connection. Bug: 752347 Change-Id: Ic35e9a250be04ae7e521fb56f82fb731bc0fb779 Reviewed-on: https://chromium-review.googlesource.com/601329 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491906} [modify] https://crrev.com/6d51c918ac7eef16ba99e0798cb0dd51a50420b9/ash/shell.cc [modify] https://crrev.com/6d51c918ac7eef16ba99e0798cb0dd51a50420b9/ash/shell.h
,
Aug 4 2017
Merge request notes: This doesn't change any behavior in M61, but puts back a utility method that I think dependent CLs will use. This should help prevent merge issues for the other patches.
,
Aug 4 2017
Approving merge to M61 Chrome OS.
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5940013d5bbaf425d710c9a83345ce68f6e045a commit a5940013d5bbaf425d710c9a83345ce68f6e045a Author: James Cook <jamescook@chromium.org> Date: Fri Aug 04 16:58:20 2017 M61 merge: cros: Restore ash::Shell::GetActiveUserPrefService I removed it in https://chromium-review.googlesource.com/c/590356 but I need it in a new CL. Also, don't delete the underlying PrefService when switching users under mash. I now think it's better for the PrefService to be transiently stale than to be null during the mojo service connection. TBR=jamescook@chromium.org (cherry picked from commit 6d51c918ac7eef16ba99e0798cb0dd51a50420b9) Bug: 752347 Change-Id: Ic35e9a250be04ae7e521fb56f82fb731bc0fb779 Reviewed-on: https://chromium-review.googlesource.com/601329 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491906} Reviewed-on: https://chromium-review.googlesource.com/602451 Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#315} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/a5940013d5bbaf425d710c9a83345ce68f6e045a/ash/shell.cc [modify] https://crrev.com/a5940013d5bbaf425d710c9a83345ce68f6e045a/ash/shell.h
,
Aug 4 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Aug 3 2017