New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752340 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tether does not send a DisconnectTetheringRequest when the user switches over to a real WiFi network

Project Member Reported by hansberry@chromium.org, Aug 3 2017

Issue description

(see summary)
 
Labels: -Pri-1 Pri-2
Downgrading to P2 because if the message doesn't get sent, it's not the end of the world. The phone will disable its hotspot automatically after a short period of inactivity.
Owner: lesliewatkins@chromium.org
Status: Assigned (was: Available)
There are 2 parts to this fix:
(1) Refactor TetherDisconnectorImpl. Currently, it disconnects from the Wi-Fi network, then sends a DisconnectTetheringRequest to the host. We need to separate these two actions so that the "sending the request" part is in its own class. Once it's part of its own class, it should be called from TetherDisconnectorImpl.
(2) When a Tether network is disconnected, send a DisconnectTetheringRequest. This should be done within TetherNetworkDisconnectionHandler; you can call into the same class that you created in part 1.
Note: For step (2), I *think* that TetherNetworkDisconnectionHandler should work, but I'm not 100% sure. Before starting the implementation for part (2), please add some logs in that class to ensure that this code path is actually executed in this situation.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c543466df28dbcfdd8b5149d2afea00b6bddcce

commit 9c543466df28dbcfdd8b5149d2afea00b6bddcce
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Sat Sep 02 02:17:47 2017

Send a DisconnectTetheringRequest in TetherNetworkDisconnectionHandler.

Previously, a DisconnectTetheringRequest was only being sent to the
Tether host when the network was explicitly disconnected (via the
"Disconnect" button in network settings). Now it is also sent when
a connection to the active host is lost (such as connecting to an
actual Wifi network).

Bug:  752340 , 672263
Change-Id: Ic1d8a5dff5295889e2e57c3fcbbc3362489da5d7
Reviewed-on: https://chromium-review.googlesource.com/617803
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499375}
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/BUILD.gn
[add] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[add] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/disconnect_tethering_request_sender_impl.h
[add] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/fake_disconnect_tethering_request_sender.cc
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/fake_disconnect_tethering_request_sender.h
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/initializer_impl.cc
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/tether_disconnector_impl.cc
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/tether_disconnector_impl.h
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/tether_disconnector_impl_unittest.cc
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/tether_network_disconnection_handler.cc
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/tether_network_disconnection_handler.h
[modify] https://crrev.com/9c543466df28dbcfdd8b5149d2afea00b6bddcce/chromeos/components/tether/tether_network_disconnection_handler_unittest.cc

Labels: Merge-Request-61
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 2 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 2 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by ketakid@google.com, Sep 4 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approved merge to M61.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 4 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5fe3489ec4365d9cfb502d66d5594356080b2d0

commit f5fe3489ec4365d9cfb502d66d5594356080b2d0
Author: Kyle Horimoto <khorimoto@google.com>
Date: Mon Sep 04 22:03:34 2017

Send a DisconnectTetheringRequest in TetherNetworkDisconnectionHandler.

Previously, a DisconnectTetheringRequest was only being sent to the
Tether host when the network was explicitly disconnected (via the
"Disconnect" button in network settings). Now it is also sent when
a connection to the active host is lost (such as connecting to an
actual Wifi network).

TBR=lesliewatkins@chromium.org

(cherry picked from commit 9c543466df28dbcfdd8b5149d2afea00b6bddcce)

Bug:  752340 , 672263
Change-Id: Ic1d8a5dff5295889e2e57c3fcbbc3362489da5d7
Reviewed-on: https://chromium-review.googlesource.com/617803
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499375}
Reviewed-on: https://chromium-review.googlesource.com/649948
Cr-Commit-Position: refs/branch-heads/3163@{#1094}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/BUILD.gn
[add] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[add] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/disconnect_tethering_request_sender_impl.h
[add] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/fake_disconnect_tethering_request_sender.cc
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/fake_disconnect_tethering_request_sender.h
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/initializer_impl.cc
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/tether_disconnector_impl.cc
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/tether_disconnector_impl.h
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/tether_disconnector_impl_unittest.cc
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/tether_network_disconnection_handler.cc
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/tether_network_disconnection_handler.h
[modify] https://crrev.com/f5fe3489ec4365d9cfb502d66d5594356080b2d0/chromeos/components/tether/tether_network_disconnection_handler_unittest.cc

Status: Fixed (was: Started)
Labels: Merge-Request-62
Status: Started (was: Fixed)
Will re-close when merge to M-62 has completed.
Labels: -Merge-Request-62 Merge-Approved-62
Approved for 62.
Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 11 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8fc29d72014e7299d4addf674ab5e72815478d8

commit d8fc29d72014e7299d4addf674ab5e72815478d8
Author: Kyle Horimoto <khorimoto@google.com>
Date: Mon Sep 11 18:19:21 2017

Send a DisconnectTetheringRequest in TetherNetworkDisconnectionHandler.

Previously, a DisconnectTetheringRequest was only being sent to the
Tether host when the network was explicitly disconnected (via the
"Disconnect" button in network settings). Now it is also sent when
a connection to the active host is lost (such as connecting to an
actual Wifi network).

TBR=lesliewatkins@chromium.org

(cherry picked from commit 9c543466df28dbcfdd8b5149d2afea00b6bddcce)

Bug:  752340 , 672263
Change-Id: Ic1d8a5dff5295889e2e57c3fcbbc3362489da5d7
Reviewed-on: https://chromium-review.googlesource.com/617803
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499375}
Reviewed-on: https://chromium-review.googlesource.com/661073
Cr-Commit-Position: refs/branch-heads/3202@{#137}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/BUILD.gn
[add] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[add] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/disconnect_tethering_request_sender_impl.h
[add] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/fake_disconnect_tethering_request_sender.cc
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/fake_disconnect_tethering_request_sender.h
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/initializer_impl.cc
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/tether_disconnector_impl.cc
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/tether_disconnector_impl.h
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/tether_disconnector_impl_unittest.cc
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/tether_network_disconnection_handler.cc
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/tether_network_disconnection_handler.h
[modify] https://crrev.com/d8fc29d72014e7299d4addf674ab5e72815478d8/chromeos/components/tether/tether_network_disconnection_handler_unittest.cc

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 17 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment