New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752338 link

Starred by 2 users
Status: Fixed
Owner:
hanxi@chromium.org
Closed: Aug 2017
Cc:
█ piotrs@chromium.org
dominickn@chromium.org
pkotw...@chromium.org
█ mcgreevy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Updates to webapk install flow ui

Project Member Reported by yfried...@chromium.org, Aug 3 2017 
Prompt: existing infobar prompt > disappears on "add" > ongoing progress notification > "added" notification to open (no snackbar/toast in Chrome.)
Menu: overflow menu A2HS > existing modal prompt we use for A2HS > "Add" again > ongoing progress notification > "added" notification to open (no snackbar/toast in Chrome.)

Per discussion with Dominick & Piotr, Peter or Xi will pick this up.

Comment 1 by yfried...@chromium.org, Aug 4 2017

Cc: -hanxi@chromium.org pkotw...@chromium.org
Owner: hanxi@chromium.org
Status: Started (was: Assigned)
Apparently Xi has already started on this!

Comment 2 by dominickn@chromium.org, Aug 4 2017

Cc: mcgreevy@chromium.org
+cc FYI mcgreevy@ in SYD who will be implementing the modal replacement for banners, probably targeting post-M62.

mcgreevy@: some of the work in this bug will be reorganising the internal banner plumbing for WebAPKs in a way that should make introducing the new modal flow easier.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5d5eef46f948ec1aa28739ce6fda52e6a673f68

commit e5d5eef46f948ec1aa28739ce6fda52e6a673f68
Author: Xi Han <hanxi@google.com>
Date: Mon Aug 21 21:03:26 2017

New WebAPK Install UI: Add from menu shows the add-to-homescreen dialog.
[2/4]

This CL includes the following UI changes:
When add to homescreen from menu, the add-to-homescreen dialog will show
first.
If user clicks the "Add" button, it triggers the app banner infobar.

Bug:  752338 
Change-Id: I93f2c974b20449638d671a963bab13dd3359102a
Reviewed-on: https://chromium-review.googlesource.com/611084
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496059}
[modify] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java
[modify] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java
[modify] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java
[modify] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[modify] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/browser/android/webapps/add_to_homescreen_manager.h
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b

commit ef0bc2e522ff357a414235b67ddfa7a66d70ab2b
Author: Xi Han <hanxi@google.com>
Date: Mon Aug 21 22:44:00 2017

New WebApk Install UI [3/4]

This CL includes the following UI changes:
1) Add to homescreen from menu will show a dialog and won't trigger an infobar.
2) After user clicks "Add" button from the app banner, the banner
   disappears.
3) Show install-in-progress notification.

It also simplifies the existing logic:
1) Simplify the logic to show the dialog in AddToHomescreenManager and data
   fetcher.
3) Remove unnecessary logic for adding from menu in AppbanerInfobarDelegate.

Bug:  752338 
Change-Id: Ie2a173f4bedb52382448a6a7fa383c2621dc7cc3
Reviewed-on: https://chromium-review.googlesource.com/611142
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496099}
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarDelegateAndroid.java
[add] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstallService.java
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/android/java_sources.gni
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/BUILD.gn
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/banners/app_banner_manager_android.cc
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/webapk/webapk_install_service.cc
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/webapk/webapk_install_service.h
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/webapk/webapk_metrics.cc
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/webapk/webapk_metrics.h
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/android/webapps/add_to_homescreen_manager.h
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/chrome/browser/ui/android/infobars/app_banner_infobar_android.h
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ef0bc2e522ff357a414235b67ddfa7a66d70ab2b/tools/metrics/histograms/histograms.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d

commit 952b661ab8c9bc94818bb8b7e8160fbbff2afc2d
Author: Xi Han <hanxi@google.com>
Date: Tue Aug 22 00:01:42 2017

New WebAPK Install UI: Polish add-to-homescreen dialog for WebAPKs. [4/4]

In the add-to-homescreen dialog, we add the name and the display-origin of the
WebAPK to install. See screenshot:
https://drive.google.com/open?id=0B7zEF5GgyYmpMC1hQjhEeWZXcEU

Potential clean up in AddToHomescreenManager/DataFetcher isn't part of this CL.

Bug:  752338 
Change-Id: I496fe11bef63e0c2af4be0f11197d9b65320e1d9
Reviewed-on: https://chromium-review.googlesource.com/614291
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496133}
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/android/java/res/layout/add_to_homescreen_dialog.xml
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/952b661ab8c9bc94818bb8b7e8160fbbff2afc2d/chrome/browser/android/webapps/add_to_homescreen_manager.h
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3006282cff13c403b6dfd88088d51cfdb1eeac

commit 5f3006282cff13c403b6dfd88088d51cfdb1eeac
Author: Xi Han <hanxi@google.com>
Date: Tue Aug 22 15:34:48 2017

Update text when installing WebAPKs.

Bug:  752338 
Change-Id: I2211d8f28052ed36ea2e9619caf6e9ea676c29d8
Reviewed-on: https://chromium-review.googlesource.com/626236
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496312}
[modify] https://crrev.com/5f3006282cff13c403b6dfd88088d51cfdb1eeac/chrome/android/java/strings/android_chrome_strings.grd

Comment 8 by hanxi@chromium.org, Aug 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment