New issue
Advanced search Search tips

Issue 752333 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Simplify access to finished_source_handlers_

Project Member Reported by rtoy@chromium.org, Aug 3 2017

Issue description

Currently there's a mutex to protect access to finished_source_handlers_ from the main thread and the audio thread.  Since this mutex can happen in the audio thread, there's a potential for blocking the audio thread.

Maybe we can simplify this by removing this mutex and adding a new variable.  The audio thread can update finished_source_handlers_ in the audio thread.  In the post render task, finished_source_handlers can be appended to a new variable.  Since there's a trylock, this new variable won't be updated if the main thread is accessing it.  If the lock succeeds, the copy can proceed and finished_source_handlers_ can be cleared safely.  It's ok to skip the copy since it will get picked up next time around.


 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment