Remove usage of cc::ElementId::GetInternalValue. |
||
Issue descriptionIt is (well, will be, shortly) used currently for cc::EffectNode.stable_id, but it's supposed to be opaque. See also https://chromium-review.googlesource.com/c/601000 Could be sufficient to just rename to GetEffectNodeStableId() with a comment noting the representation is the same.
,
Aug 3 2017
Per opening comment, could be renamed to GetEffectNodeStableId() so that it is at least clear that it is specifically only for use for that purpose.
,
Dec 7 2017
Unassigning self as someone else on Paint or cc will need to field.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca commit 4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca Author: Stefan Zager <szager@chromium.org> Date: Fri Jul 13 20:20:35 2018 CompositorElementId: s/ToInternalValue/GetInternalValue/ This is only necessary to eliminate a presubmit error about the use of the banned method Time::ToInternalValue. No functional change. BUG=752327 R=chrishtr@chromium.org,vmpstr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id0ecab92b4605da1c25398a539be7dc87a250547 Reviewed-on: https://chromium-review.googlesource.com/1135988 Reviewed-by: vmpstr <vmpstr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#575046} [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/cc/trees/element_id.cc [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/cc/trees/element_id.h [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/third_party/blink/renderer/platform/graphics/compositor_element_id.cc [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/third_party/blink/renderer/platform/graphics/compositor_element_id.h [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/third_party/blink/renderer/platform/graphics/compositor_element_id_test.cc [modify] https://crrev.com/4fdba5d4d7a7a788f77054ecf4a94aaf5b55b1ca/third_party/blink/renderer/platform/scroll/scrollable_area.cc |
||
►
Sign in to add a comment |
||
Comment 1 by chrishtr@chromium.org
, Aug 3 2017