New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752322 link

Starred by 1 user
Status: Assigned
Owner:
jarhar@chromium.org
Cc:
█ allada@chromium.org
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Network throttling does not work in Android Webview

Reported by rc...@quora.com, Aug 3 2017 
Steps to reproduce the problem:
In an app with a webview and debugging enabled:

1. Enable network throttling, disable cache
2. Reload page
3. Look at network tab after page load

What is the expected behavior?
Load of resources should be slowed down compared to un-throttled

What went wrong?
Resources load just as fast as without throttling. In the screenshot, notice that the resources are loading much faster than the selected throttling should allow.

Did this work before? N/A 

Chrome version: 59.0.3071.125  Channel: stable
OS Version: 6.0.1
Flash Version: n/a

This works on the same device in Chrome
Screen Shot 2017-08-03 at 3.26.23 PM.png
164 KB View Download

Comment 1 by eostroukhov@chromium.org, Aug 4 2017

Owner: allada@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by caseq@chromium.org, Sep 13 2017

Cc: dgozman@chromium.org allada@chromium.org
Components: -Platform>DevTools Platform>DevTools>Network
Owner: caseq@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f33167852983f3cee26b69639baa36db7b4358

commit 24f33167852983f3cee26b69639baa36db7b4358
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Sep 14 22:41:40 2017

Move DevTools network throttling to content layer

This moves the implementation of DevTools' network throttling to content.
Core of the implementation is now under content/common, so it can be reused
in the network service.
Needed drive-by changes include making DevToolsNetworkController a
singleton, which also allowed to nuke DevToolsNetworkControllerHandle and
some other simplifications.

Bug:  721408 , 752322
Change-Id: I71b84aa62f7ffad8f8df5fba7fe36dc2ba4b27e6
Reviewed-on: https://chromium-review.googlesource.com/664356
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502052}
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/android/devtools_manager_delegate_android.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/android/devtools_manager_delegate_android.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/devtools/chrome_devtools_manager_delegate.h
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_conditions.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller.h
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller_handle.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller_handle.h
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_protocol_handler.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_protocol_handler.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_impl.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/ui/app_list/test/fake_profile.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/ui/app_list/test/fake_profile.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/test/BUILD.gn
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/test/base/testing_profile.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/BUILD.gn
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/devtools_network_transaction_factory.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/worker_devtools_agent_host.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/BUILD.gn
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_conditions.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_conditions.h
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_controller.cc
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_controller.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_controller_unittest.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_interceptor.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_interceptor.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction_factory.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction_factory.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_upload_data_stream.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_upload_data_stream.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/public/browser/BUILD.gn
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/public/browser/devtools_network_transaction_factory.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/test/BUILD.gn

Comment 4 by jarhar@chromium.org, Sep 18

Owner: jarhar@chromium.org

Comment 5 by jarhar@chromium.org, Sep 18

Owner: caseq@chromium.org
This bug was assigned to me this morning along with a bunch of other network bugs, but since caseq@ already marked it as started and submitted a patch for it, I am assigning it back to him. Feel free to assign it back to me if you want me to work on it.

Comment 6 by jarhar@chromium.org, Nov 9

Owner: jarhar@chromium.org
Status: Assigned (was: Started)
►

Sign in to add a comment