New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752283 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Video ending while seeking video in default media player

Project Member Reported by avkodipelli@chromium.org, Aug 3 2017

Issue description

Chrome Version: 61.0.3163.30
Chrome OS Version: 9765.16.0 
Chrome OS Platform: All
Network info: Wifi

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Start playing any video in default video player
(2) Seek video to different position 
(3) Observe video behavior

Expected Result:
Video play from new seek position
Actual Result:
Video ended
How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always
What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.
Feedback ID: 69850248011

Issue not observed while playing videos in HTML5 player
 
Labels: M-62
Issue also observed in M62(9807.0.0, 62.0.3176.0)
Same behavior observed with volume bar also. Unable to reduce the volume. able to mute but not able to reduce volume.

Comment 3 by vsu...@chromium.org, Aug 25 2017

Cc: keta...@chromium.org
Same issue observed in Version 61.0.3163.70 (Official Build) beta
Cc: -fukino@chromium.org weifangsun@chromium.org
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)
fukino@ - Can we investigate this for a bug fix for M62? We are getting a few reports about this being broken.

Comment 6 by fukino@chromium.org, Aug 31 2017

Status: Started (was: Assigned)
I'll look into this.

Comment 7 by fukino@chromium.org, Aug 31 2017

Cc: taku...@chromium.org
This issue starts from https://chromium-review.googlesource.com/565067
There might be a breaking change in paper-slider v1.0.15 -> v2.0.2
I'll look into how to fix the issue.
Cc: keanulee@chromium.org
+keanulee from Polymer.

Here [1] are the changes between v1.0.15 and v2.0.2.
I'm not familiar with this codebase, but at a cursory glance I see that many values in paper-slider.html were either multiplied or divided by 100. That might be relevant?

[1] https://github.com/PolymerElements/paper-slider/compare/v1.0.15...v2.0.2
Yes, that was a change I made to fix this long-standing issue (https://github.com/PolymerElements/paper-slider/pull/194). Going forward, ratio will be between 0-100.
Labels: Hotlist-ConOps
Thanks.
The fix will be straightforward (i.e. will divide |ratio| returned by paper-slider by 100 in video player).

As far as I checked, the |ratio| property is not referred in chrome://settings, so the Settings page should not be affected.
Re: #5
I'll request a merge of the fix to M61 too, since the sliders for both seek and volume are not usable by this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d2a76092eeeae60ce48ed5690567bd8f1dfbb0

commit 81d2a76092eeeae60ce48ed5690567bd8f1dfbb0
Author: Naoki Fukino <fukino@chromium.org>
Date: Fri Sep 01 04:40:13 2017

Video player: Interpret paper-slider's ratio property properly.

paper-slider v2.0.2 has a breaking change.
https://github.com/PolymerElements/paper-slider/pull/194
|ratio| property used to return a value in [0, 1], but now it returns a value in
[0, 100].
Making video player to catch up this change by dividing |ratio| property by 100.

Bug:  752283 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iad994a2dd7f8a6e5b77698a0deec0812c70fb045
Reviewed-on: https://chromium-review.googlesource.com/646153
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499126}
[modify] https://crrev.com/81d2a76092eeeae60ce48ed5690567bd8f1dfbb0/ui/file_manager/video_player/js/media_controls.js

Labels: Merge-Request-61
Project Member

Comment 15 by sheriffbot@chromium.org, Sep 1 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approved merge to M61.
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 4 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b32e7eca17598618017f5402b66ca2781a0eccc9

commit b32e7eca17598618017f5402b66ca2781a0eccc9
Author: Naoki Fukino <fukino@chromium.org>
Date: Mon Sep 04 03:49:38 2017

Video player: Interpret paper-slider's ratio property properly.

paper-slider v2.0.2 has a breaking change.
https://github.com/PolymerElements/paper-slider/pull/194
|ratio| property used to return a value in [0, 1], but now it returns a value in
[0, 100].
Making video player to catch up this change by dividing |ratio| property by 100.

TBR=fukino@chromium.org

(cherry picked from commit 81d2a76092eeeae60ce48ed5690567bd8f1dfbb0)

Bug:  752283 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iad994a2dd7f8a6e5b77698a0deec0812c70fb045
Reviewed-on: https://chromium-review.googlesource.com/646153
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499126}
Reviewed-on: https://chromium-review.googlesource.com/647508
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1093}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b32e7eca17598618017f5402b66ca2781a0eccc9/ui/file_manager/video_player/js/media_controls.js

Labels: Merge-Request-62
Requesting a merge to M62 too.
Project Member

Comment 19 by sheriffbot@chromium.org, Sep 5 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 5 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02a0ff2716c6dce7d154fda96d9ae3a00957211e

commit 02a0ff2716c6dce7d154fda96d9ae3a00957211e
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Sep 05 06:12:05 2017

Video player: Interpret paper-slider's ratio property properly.

paper-slider v2.0.2 has a breaking change.
https://github.com/PolymerElements/paper-slider/pull/194
|ratio| property used to return a value in [0, 1], but now it returns a value in
[0, 100].
Making video player to catch up this change by dividing |ratio| property by 100.

TBR=fukino@chromium.org

(cherry picked from commit 81d2a76092eeeae60ce48ed5690567bd8f1dfbb0)

Bug:  752283 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iad994a2dd7f8a6e5b77698a0deec0812c70fb045
Reviewed-on: https://chromium-review.googlesource.com/646153
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499126}
Reviewed-on: https://chromium-review.googlesource.com/650186
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#19}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/02a0ff2716c6dce7d154fda96d9ae3a00957211e/ui/file_manager/video_player/js/media_controls.js

Status: Fixed (was: Started)
Verified on 9765.61.0, 61.0.3163.87. 
Status: Verified (was: Fixed)
Verified on 9901.12.0, 62.0.3202.18

Sign in to add a comment