New issue
Advanced search Search tips

Issue 752279 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Always verify the type of log in EXPECT_MEDIA_LOG(...) test utility usage

Project Member Reported by wolenetz@chromium.org, Aug 3 2017

Issue description

Since we now do variable behavior in production based on the log type (eg, we take the first, if any, ERROR event log and use it in a later, if any, MediaError.message construction), we should update our unit test's EXPECT_MEDIA_LOG() utility (and its callers) to also verify the *type* of the log entry (info/debug/error) (or info/warning/error once bug 737768 gets fixed) matches expectation.

Credit to xhwang@ for suggesting this!
 
See https://cs.chromium.org/chromium/src/media/filters/ffmpeg_demuxer_unittest.cc?q=ffmpeg_demuxer_unit&sq=package:chromium&l=69 for a few small cases where we manually verify log event type in the calling test today..
Description: Show this description

Sign in to add a comment