Since we now do variable behavior in production based on the log type (eg, we take the first, if any, ERROR event log and use it in a later, if any, MediaError.message construction), we should update our unit test's EXPECT_MEDIA_LOG() utility (and its callers) to also verify the *type* of the log entry (info/debug/error) (or info/warning/error once bug 737768 gets fixed) matches expectation.
Since we now do variable behavior in production based on the log type (eg, we take the first, if any, ERROR event log and use it in a later, if any, MediaError.message construction), we should update our unit test's EXPECT_MEDIA_LOG() utility (and its callers) to also verify the *type* of the log entry (info/debug/error) (or info/warning/error once bug 737768 gets fixed) matches expectation.
Credit to xhwang@ for suggesting this!
Comment 1 by wolenetz@chromium.org
, Aug 3 2017