New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752271 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

EventDispatcherTest.WheelWhileDown in services_unittests fails on UbsanVptr bot

Project Member Reported by thakis@chromium.org, Aug 3 2017

Issue description

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTLinuxUBSanVptr_tester%2F1447%2F%2B%2Frecipes%2Fsteps%2Fservices_unittests%2F0%2Flogs%2FEventDispatcherTest.WheelWhileDown__x2f_0%2F0


[ RUN      ] EventDispatcherTest.WheelWhileDown/0
../../ui/events/event.cc:329:10: runtime error: downcast of address 0x7ffe519be580 which does not point to an object of type 'const ui::MouseWheelEvent'
0x7ffe519be580: note: object is of type 'ui::MouseEvent'
 00 00 00 00  f8 14 a5 09 00 00 00 00  09 00 00 00 43 5e 44 ff  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'ui::MouseEvent'
    #0 0x3a8ee1a  (/b/s/w/ir/out/Release/services_unittests+0x3a8ee1a)
    #1 0x3a97ac2  (/b/s/w/ir/out/Release/services_unittests+0x3a97ac2)
    #2 0x786845  (/b/s/w/ir/out/Release/services_unittests+0x786845)
    #3 0x79acd1  (/b/s/w/ir/out/Release/services_unittests+0x79acd1)
    #4 0xaff853  (/b/s/w/ir/out/Release/services_unittests+0xaff853)
    #5 0xb01815  (/b/s/w/ir/out/Release/services_unittests+0xb01815)
    #6 0xb031d2  (/b/s/w/ir/out/Release/services_unittests+0xb031d2)
    #7 0xb145d7  (/b/s/w/ir/out/Release/services_unittests+0xb145d7)
    #8 0xb134fa  (/b/s/w/ir/out/Release/services_unittests+0xb134fa)
    #9 0x36f16e5  (/b/s/w/ir/out/Release/services_unittests+0x36f16e5)
    #10 0x36fc8e3  (/b/s/w/ir/out/Release/services_unittests+0x36fc8e3)
    #11 0x36fc729  (/b/s/w/ir/out/Release/services_unittests+0x36fc729)
    #12 0x235d877  (/b/s/w/ir/out/Release/services_unittests+0x235d877)
    #13 0xa04a55  (/b/s/w/ir/out/Release/services_unittests+0xa04a55)
    #14 0x7f19c29c3f44  (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
    #15 0x49944a  (/b/s/w/ir/out/Release/services_unittests+0x49944a)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/252b10b3df024dc7a00d43d3c810c6d5b9086274

commit 252b10b3df024dc7a00d43d3c810c6d5b9086274
Author: Elliot Glaysher <erg@chromium.org>
Date: Thu Aug 03 23:16:02 2017

Don't slice ui::MouseWheelEvents in tests.

This fixes an ubisan error in ws::EventDispatcher where the creation of a
ui::MouseWheelEvent object was copied into a ui::MouseEvent object, and then
near immediately casted back to a ui::MouseWheelEvent, which it no longer was
because the object was sliced.

Bug:  752271 
Change-Id: I9e49369c0ff599b99c1b68ab3785bdd051998568
Reviewed-on: https://chromium-review.googlesource.com/601179
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491872}
[modify] https://crrev.com/252b10b3df024dc7a00d43d3c810c6d5b9086274/services/ui/ws/event_dispatcher_unittest.cc

Comment 2 by e...@chromium.org, Aug 3 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment