New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752254 link

Starred by 1 user
Status: Fixed
Owner:
█ yichunli@google.com
Email to this user bounced
Closed: Aug 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: Bug
Launch-Accessibility: NA
Launch-Legal: NA
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA



Sign in to add a comment

Record warning in ninja wrapper

Project Member Reported by yichunli@google.com, Aug 3 2017 
Feature description:
If ninja wrapper meets exception or unexpected input, save warnings in wrapper's output file.

Eng owner: @yichunli

Comment 1 by yichunli@google.com, Aug 3 2017

Labels: -Type-Launch Type-Bug
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4f67c81667d0176a6b3cd1f79901ef9833ffd760

commit 4f67c81667d0176a6b3cd1f79901ef9833ffd760
Author: Yichun Li <yichunli@google.com>
Date: Thu Aug 10 23:00:58 2017

[ninja wrapper]Add warning to output file

Bug:  752254 
Change-Id: Ibb50157fb1ba27274e3402a1c08adf2925b01bda
Reviewed-on: https://chromium-review.googlesource.com/601255
Commit-Queue: Yichun Li <yichunli@google.com>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/4f67c81667d0176a6b3cd1f79901ef9833ffd760/scripts/slave/recipe_modules/chromium/resources/ninja_wrapper.py
[modify] https://crrev.com/4f67c81667d0176a6b3cd1f79901ef9833ffd760/scripts/slave/recipe_modules/chromium/resources/ninja_wrapper_test.py
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 17 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "yichunli@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by st...@chromium.org, Aug 17 2017

Owner: yichunli@google.com
Status: Assigned (was: Untriaged)

Comment 5 by st...@chromium.org, Aug 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment