We currently have many targets that depend on: //third_party/android_tools:google_play_services_default_java But this causes more or play services to be pulled in than what is required.
Initially fixed at: https://chromium-review.googlesource.com/585450 And reverted: https://chromium-review.googlesource.com/596807
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/0c3036f8fb8c75b4c7af6025d6e768c2eef73147 commit 0c3036f8fb8c75b4c7af6025d6e768c2eef73147 Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Aug 04 00:28:39 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9 commit 2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9 Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Aug 04 14:16:43 2017 Reland of Android: Make all targets depend on specific play services targets This is a reland of cfa74c5047c1a580a16e7de8950762a0c67c1a3f Reverted in https://chromium-review.googlesource.com/c/596807 Reason for reland: Downstream has a fix for the issue. Deletes google_play_services_library GN variable. This should reduce compile times a bit, but mostly is just a good idea in general. TBR=paulmiller@chromium.org Bug: 752238 Change-Id: I0c4c9548256166aa90280850f84fa17385c1ad9c Reviewed-on: https://chromium-review.googlesource.com/600636 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#492021} [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/build/config/android/config.gni [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/chrome/android/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/chrome/test/android/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/chrome/test/android/cast_emulator/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/components/background_task_scheduler/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/components/gcm_driver/instance_id/android/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/components/signin/core/browser/android/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/components/sync/android/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/remoting/android/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/remoting/android/client_java_tmpl.gni [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/third_party/cacheinvalidation/BUILD.gn [modify] https://crrev.com/2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9/third_party/robolectric/BUILD.gn
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/aee700f06a6a6c98c23816af8f4f2c2e725fc39c commit aee700f06a6a6c98c23816af8f4f2c2e725fc39c Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Aug 09 15:12:26 2017
Comment 1 by agrieve@chromium.org
, Aug 3 2017