New issue
Advanced search Search tips

Issue 752234 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add CQ builder support for unified builds

Project Member Reported by shapiroc@chromium.org, Aug 3 2017

Issue description

CQ checks are needed to avoid regressions for uni builds currently.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1342348f9fa2b7959feb7dac98ce93a927b90ca8

commit 1342348f9fa2b7959feb7dac98ce93a927b90ca8
Author: C Shapiro <shapiroc@chromium.org>
Date: Tue Aug 08 21:56:14 2017

Add unibuild support for Cq paladin builders

Unified builds are experiencing constant regressions since there is no
CQ validation for unified builds currently.  This will add unibuilds to
the paladin builders.

This also begins treating reef-uni like any other normal board in
terms of builder config.  For testing purposes, only builders that
invoke hw_tests or au tests need custom support in buildbot; otherwise,
the builders should just work.

Only non-experimental builders will be added to the CQ waterfall.

BUG= chromium:752234 
TEST=cbuildbot --remote -g 600543 reef-uni-paladin

Change-Id: I492ec3275a0735a730ffb8104ac607b7f4f25f51
Reviewed-on: https://chromium-review.googlesource.com/600543
Commit-Ready: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/1342348f9fa2b7959feb7dac98ce93a927b90ca8/cbuildbot/config_dump.json
[modify] https://crrev.com/1342348f9fa2b7959feb7dac98ce93a927b90ca8/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/1342348f9fa2b7959feb7dac98ce93a927b90ca8/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/1342348f9fa2b7959feb7dac98ce93a927b90ca8/cbuildbot/chromeos_config.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5dc51d80f13c83c63a385db19245e9932c6e7e54

commit 5dc51d80f13c83c63a385db19245e9932c6e7e54
Author: Don Garrett <dgarrett@chromium.org>
Date: Tue Aug 08 23:29:21 2017

Revert "Add unibuild support for Cq paladin builders"

This reverts commit 1342348f9fa2b7959feb7dac98ce93a927b90ca8.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add unibuild support for Cq paladin builders
> 
> Unified builds are experiencing constant regressions since there is no
> CQ validation for unified builds currently.  This will add unibuilds to
> the paladin builders.
> 
> This also begins treating reef-uni like any other normal board in
> terms of builder config.  For testing purposes, only builders that
> invoke hw_tests or au tests need custom support in buildbot; otherwise,
> the builders should just work.
> 
> Only non-experimental builders will be added to the CQ waterfall.
> 
> BUG= chromium:752234 
> TEST=cbuildbot --remote -g 600543 reef-uni-paladin
> 
> Change-Id: I492ec3275a0735a730ffb8104ac607b7f4f25f51
> Reviewed-on: https://chromium-review.googlesource.com/600543
> Commit-Ready: C Shapiro <shapiroc@google.com>
> Tested-by: C Shapiro <shapiroc@google.com>
> Reviewed-by: C Shapiro <shapiroc@google.com>

Bug:  chromium:752234 
Change-Id: Ibf04b502105d6ba3baa667b11380c3b76e64c1ed
Reviewed-on: https://chromium-review.googlesource.com/607448
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/5dc51d80f13c83c63a385db19245e9932c6e7e54/cbuildbot/config_dump.json
[modify] https://crrev.com/5dc51d80f13c83c63a385db19245e9932c6e7e54/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/5dc51d80f13c83c63a385db19245e9932c6e7e54/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/5dc51d80f13c83c63a385db19245e9932c6e7e54/cbuildbot/chromeos_config.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c519df078a0e075f0959da7eff8fd35510216127

commit c519df078a0e075f0959da7eff8fd35510216127
Author: C Shapiro <shapiroc@chromium.org>
Date: Wed Aug 09 22:25:26 2017

Add unibuild support for Cq paladin builders

Unified builds are experiencing constant regressions since there is no
CQ validation for unified builds currently.  This will add unibuilds to
the paladin builders.

This also begins treating reef-uni like any other normal board in
terms of builder config.  For testing purposes, only builders that
invoke hw_tests or au tests need custom support in buildbot; otherwise,
the builders should just work.

BUG= chromium:752234 
TEST=cbuildbot --remote -g 608610 reef-uni-paladin

Change-Id: I5c0cd2fc2071fe2df0063e44d195a446a03164fb
Reviewed-on: https://chromium-review.googlesource.com/608610
Trybot-Ready: C Shapiro <shapiroc@google.com>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: C Shapiro <shapiroc@google.com>
Commit-Queue: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/c519df078a0e075f0959da7eff8fd35510216127/cbuildbot/config_dump.json
[modify] https://crrev.com/c519df078a0e075f0959da7eff8fd35510216127/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/c519df078a0e075f0959da7eff8fd35510216127/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/c519df078a0e075f0959da7eff8fd35510216127/cbuildbot/chromeos_config.py

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7d71dac58a43b59cc21a55d7d6923d50d9e86b1d

commit 7d71dac58a43b59cc21a55d7d6923d50d9e86b1d
Author: C Shapiro <shapiroc@chromium.org>
Date: Mon Aug 14 21:57:24 2017

Make reef-uni important in paladin builders

BUG= chromium:752234 
TEST=None - current builds are green

Change-Id: Ia3301307954b0555ecf951bd8e732207efaa4ab4
Reviewed-on: https://chromium-review.googlesource.com/611959
Commit-Ready: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/7d71dac58a43b59cc21a55d7d6923d50d9e86b1d/cbuildbot/config_dump.json
[modify] https://crrev.com/7d71dac58a43b59cc21a55d7d6923d50d9e86b1d/cbuildbot/chromeos_config.py

Status: Assigned (was: Fixed)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6fc85903ee07273d593afd5d997a9cf406741630

commit 6fc85903ee07273d593afd5d997a9cf406741630
Author: C Shapiro <shapiroc@chromium.org>
Date: Fri Aug 18 21:27:23 2017

[unibuild] Per model control of CQ hw tests

There were hardware provisioning issues with unified builds.  We have
since fixed this for reef-uni and added 8 snappy boards.

This change updates the config to respect the GoldenEye config to
determine which models for a given unified build should actually be
tested.

If no models are configured for presubmit testing, it will skip any
hardware testing for the given build.

BUG= chromium:752234 
TEST=./chromeos_config_unittest

Change-Id: Ic91ae6a87fb75cd93ff11875418154f66277e81d
Reviewed-on: https://chromium-review.googlesource.com/619630
Commit-Ready: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/6fc85903ee07273d593afd5d997a9cf406741630/cbuildbot/config_dump.json
[modify] https://crrev.com/6fc85903ee07273d593afd5d997a9cf406741630/lib/config_lib.py
[modify] https://crrev.com/6fc85903ee07273d593afd5d997a9cf406741630/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/6fc85903ee07273d593afd5d997a9cf406741630/cbuildbot/chromeos_config.py

Status: Fixed (was: Assigned)

Sign in to add a comment