New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752232 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

NewTabPageRecyclerViewTests newly flaky on K and L tablet bots

Project Member Reported by jbudorick@chromium.org, Aug 3 2017

Issue description

Cc: mvanouwe...@chromium.org
mvanouwerkerk: could this be related to https://chromium-review.googlesource.com/c/595981?
Yes, it could be. I'll take a look.
Cc: -mvanouwe...@chromium.org
Owner: mvanouwe...@chromium.org
Status: Assigned (was: Available)
Components: UI>Browser>NewTabPage
Labels: zine-client
Reverted patch in https://chromium-review.googlesource.com/c/602209. Should fix the flake.

Comment 6 by fi...@chromium.org, Aug 7 2017

Labels: zine-triaged
Status: Fixed (was: Assigned)
Does not seem to be flaking any more.
Status: Started (was: Fixed)
The culprit CL was reverted, but I still need this fixed :-) Coming up.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c406aaecb3a05fc6ea931e003fdcf2f3d58560c

commit 9c406aaecb3a05fc6ea931e003fdcf2f3d58560c
Author: Michael van Ouwerkerk <mvanouwerkerk@google.com>
Date: Tue Aug 22 10:17:36 2017

Add entry to test config for NTPCondensedLayout with small logo.

Fix some tests that don't handle the condensed layout well.

Bug: 720383,  752232 
Change-Id: I282b3fa1b2c97385ea3fbd7c68b2b76ed525c05d
Reviewed-on: https://chromium-review.googlesource.com/624155
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496268}
[modify] https://crrev.com/9c406aaecb3a05fc6ea931e003fdcf2f3d58560c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/9c406aaecb3a05fc6ea931e003fdcf2f3d58560c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
[modify] https://crrev.com/9c406aaecb3a05fc6ea931e003fdcf2f3d58560c/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Started)

Sign in to add a comment