New issue
Advanced search Search tips

Issue 752227 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[WebPayments] Settings link is wrong shade of blue

Project Member Reported by tmartino@chromium.org, Aug 3 2017

Issue description

Currently the settings link on the Payment Sheet is #0000FF (i.e., 100% blue, 0% red/green) which is not really a color that's used much. It should probably match the action buttons, which are a subtler shade of blue.

It's not completely obvious which color enum value should be used to get the right shade, and it's possible that on Mac; several of the seemingly-likely candidates just turn the text black, which sort of reminds me of  crbug.com/732889 
 
Cc: tmartino@chromium.org anthonyvd@chromium.org
 Issue 753389  has been merged into this issue.
Per UX, it should be #3367D6 (Google Blue 700)
Woot, that's super helpful. Thanks!
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e08b68a95cc8be2f93bf963dc491837efdcce74b

commit e08b68a95cc8be2f93bf963dc491837efdcce74b
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed Aug 09 19:32:40 2017

[WebPayments] Correcting shade of blue for settings link

Bug:  752227 
Change-Id: Ic17fb47b8b612b14dc3fcf0cbdb41cdf82c0f9e9
Reviewed-on: https://chromium-review.googlesource.com/608836
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493098}
[modify] https://crrev.com/e08b68a95cc8be2f93bf963dc491837efdcce74b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Status: Fixed (was: Started)

Sign in to add a comment