[autofill] Type predictions not shown on query failure |
||
Issue description
Chrome Version: all
OS: all
After parsing forms, the autofill manager defers sending the
predicted types for queryable forms to the render until the
query has completed. If the server predictions don't arrive,
the heuristic precictions are never sent to the renderer.
This CL sends the predictions for the queryable forms after
initial parse (the non-queryable predictions are already
sent). If and when the query completes, the predictions are
updated as per the current flow.
What steps will reproduce the problem?
(1) Turn on --show-autofill-type-predictions in chrome://flags or
from the command line.
(2) Visit https://panera.custhelp.com/app/ask
(3) Hover over the First Name field.
At the time of this writing, chrome doesn't get a valid server response for this form. The heuristics run for the form, but the code to inform the renderer of the predicted types doesn't get updated by a server response. Chrome defers informing the renderer of the predictions until after receiving the response... so the renderer is never informed of the predictions.
What is the expected result?
You should see a hover hint describing the overall, server and heuristic types etc. for the field. The server response should be NO_SERVER_DATA.
What happens instead?
You see nothing, or a generic hint to enter the first name.
,
Aug 15 2017
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e0ec179730075b19ae6bd8c5a43a2e0219e42d3 commit 8e0ec179730075b19ae6bd8c5a43a2e0219e42d3 Author: Roger McFarlane <rogerm@chromium.org> Date: Tue Aug 15 17:12:58 2017 [autofill] Add missing test. To avoid regressions, adds a test to validate that when forms are encountered, the type predictions are appropriately queue to be sent to the renderer. Note that this new test validates that the AutofillDriver's SendAutofillTypePredictionsToRender is called appropriately by the AutofillManager. It does not tests for the AutofillDriver's imkplementation of the method. BUG= 752225 , 754219 Change-Id: I89a56af5949bffc6245f4bdfb608297fedcdca48 Reviewed-on: https://chromium-review.googlesource.com/615383 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: mahmadi (Moe) <mahmadi@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#494422} [modify] https://crrev.com/8e0ec179730075b19ae6bd8c5a43a2e0219e42d3/components/autofill/core/browser/autofill_manager_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 3 2017