generate_build_files fails on GPU FYI Linux Chromium OS Ozone builder. |
|||||||||||
Issue descriptionFrom the logs https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/27533 ERROR at //components/wallpaper/wallpaper_info.h:9:11: Include not allowed. #include "components/user_manager/user.h" ^----------------------------- It is not in any dependency of //components/wallpaper:wallpaper The include file is in the target(s): //ash/public/interfaces:interfaces_internal which should somehow be reachable.
,
Aug 3 2017
,
Aug 3 2017
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/27778 is green. Thanks for fixing!
,
Aug 4 2017
Issue 752331 has been merged into this issue.
,
Aug 4 2017
To answer dcastagna@'s questions from issue 752331 . I'm not sure what "bot owner" means, but fjhenigman@ should be knowledgeable about this one, since he added it. This bot is not part of the CQ, but we are wondering if we perhaps should add it, considering it was broken twice this week.
,
Aug 7 2017
rjkroege@, thomasanderson@: can/should we add trybots that mimic the configuration on this builder which is currently only on chromium.gpu.fyi? I thought that all of the ChromiumOS trybots had already been switched to this bot's configuration. fjhenigman@ is the main point of contact though.
,
Aug 8 2017
,
Aug 8 2017
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
Pls apply appropriate OSs. Thank you.
,
Aug 9 2017
,
Aug 9 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2f700f98bf4aef229e6a8952123c42de85a1288 commit c2f700f98bf4aef229e6a8952123c42de85a1288 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Aug 10 18:32:24 2017 Move |user_manager::User::WallpaperType| to components/wallpaper This could be the first step of the larger effort to clean up wallpaper codes. Due to legacy reasons WallpaperType exists in user_manager::User but it's supposed to be in WallpaperInfo together with WallpaperLayout This fixes the bot failure listed in the bug, though it's not the direct cause, it's good to refactor like this in the long term. TBR=brettw@chromium.org, ochang@chromium.org, wzang@chromium.org (cherry picked from commit 3ae357a3bbfb236e6930a09166a69d002fdb9dd2) Bug: 752215 Change-Id: Icdcfc47ac12772576f4abb18003aab935897dc3b Reviewed-on: https://chromium-review.googlesource.com/600927 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491877} Reviewed-on: https://chromium-review.googlesource.com/610925 Cr-Commit-Position: refs/branch-heads/3163@{#444} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/ash/accelerators/debug_commands.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/ash/public/cpp/wallpaper_struct_traits.h [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/ash/public/interfaces/wallpaper.mojom [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/ash/public/interfaces/wallpaper.typemap [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/ash/wallpaper/test_wallpaper_delegate.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/ash/wallpaper/wallpaper_controller_test_api.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/chrome/browser/chromeos/extensions/wallpaper_api.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/chrome/browser/chromeos/extensions/wallpaper_private_api.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/components/user_manager/user.h [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/components/wallpaper/DEPS [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/components/wallpaper/wallpaper_info.h [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/components/wallpaper/wallpaper_manager_base.cc [modify] https://crrev.com/c2f700f98bf4aef229e6a8952123c42de85a1288/components/wallpaper/wallpaper_manager_base.h |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 3 2017