[WPT Export] Move from hard-coded commit and PR windows to date-based windows |
|
Issue descriptionVia issue 737898 Instead of relying on hard-coded constants to define the commit and PR window history size, they should be date-based windows (for instance, all commits and PRs in the last 3 months) and that date window should be documented somewhere so people know there is a time limit and upstreaming will be their responsibility thereafter. Specifically the windows that need to be changed are: DEFAULT_COMMIT_HISTORY_WINDOW https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py#20 pr_history_window https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py#26
,
Dec 1 2017
One point we missed before: GitHub actually only provides the first 1000 search results under all situations. https://developer.github.com/v3/search/#about-the-search-api So the current pr_history_window of 5000 does not even make sense. And we are actually approaching this 1000 limit soon so we might want to review the system to make sure nothing breaks.
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/595965c8e3fdbe84026288ffd8bf2f1335f26d17 commit 595965c8e3fdbe84026288ffd8bf2f1335f26d17 Author: Robert Ma <robertma@chromium.org> Date: Thu Jun 07 16:59:18 2018 [WPT sync] Double the default history window for landed commits This CL only increases the default history window size for *landed commits* to 10000, which is about a month's worth of commits. The history window size for GitHub PRs and Gerrit CLs are not changed. Landed commits are scanned locally (using git), which is pretty fast (takes few minutes), so doubling the history window won't affect total run time too much. Bug: 752214 Change-Id: Id2f498aa1d8a8adb8369fe7553c73662e5b02343 Reviewed-on: https://chromium-review.googlesource.com/1085556 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#565302} [modify] https://crrev.com/595965c8e3fdbe84026288ffd8bf2f1335f26d17/third_party/blink/tools/blinkpy/w3c/chromium_exportable_commits.py |
|
►
Sign in to add a comment |
|
Comment 1 by robertma@chromium.org
, Aug 17 2017