New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752212 link

Starred by 2 users
Status: Fixed
Owner:
vapier@chromium.org
Closed: Aug 2017
Cc:
akes...@chromium.org
dgarr...@chromium.org
vapier@chromium.org
d...@chromium.org
█ nxia@chromium.org
st...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromite: argparse copy is old/buggy (removes double dash when parsing command line arguments)

Project Member Reported by yichunli@google.com, Aug 3 2017 
Chrome Version       : 59.0.3071.115
OS Version: 
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Use cros_chrome_sdk wrapper to run ninja wrapper. Ninja wrapper runs ninja build command.
2. Final command line is like: depot_tools/cros chrome_sdk --some_args -- python -u ninja_wrapper.py -- ninja -C build_dir target


What is the expected result?
Ninja wrapper should receive args: -- ninja -C build_dir target

What happens instead of that?
Double dash is removed after cros_chrome_sdk wrapper parsing the cmd. So ninja wrapper receives args: ninja -C build_dir target, which causes argument parse error.


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Comment 1 by d...@chromium.org, Aug 3 2017

Cc: akes...@chromium.org vapier@chromium.org nxia@chromium.org dgarr...@chromium.org
+some CrOS team members.

Comment 2 by vapier@chromium.org, Aug 3 2017

Summary: chromite: argparse copy is old/buggy (removes double dash when parsing command line arguments) (was: cros_chrome_sdk wrapper removes double dash when parsing command line arguments)
it's a bug in argparse, but specifically in the copy of argparse we ship.  i tried to scrub it previously, but there's some circular deps laying around that prevented me from doing so.

i guess in the mean time we should just pull our copy of argparse up to something newer.

Comment 3 by dgarr...@chromium.org, Aug 3 2017 

Our copy of argparse has local patches installed. I'd love to remove it an use the builtin instead, but didn't have time to address the custom behaviors when I was looking at it.

Comment 4 by vapier@chromium.org, Aug 3 2017

Owner: vapier@chromium.org
Status: Started (was: Unconfirmed)
i'll just take it since i've already made the changes locally

Comment 5 by d...@chromium.org, Aug 3 2017 

Hey - debating whether or not we should land a workaround or if this will be fixed soon. Any chance you can offer an ETA for a fix taking effect in "depot_tools"?

Comment 6 by vapier@chromium.org, Aug 3 2017 

i've already posted CLs, but i don't see why we're talking about ETAs here.  this bug has been here for 5+ years, and only till today did a random dev happen to notice.  doesn't sound like something to get worked up over.

Comment 7 by st...@chromium.org, Aug 3 2017 

Background: my intern (leaving next week) tried to land a recipe change yesterday, but it got reverted due to this bug. We debug and come up with a CL to workaround it. But if this bug could be fixed sooner, we'd prefer to land the original CL instead. Thus, we are asking for an ETA :)

Many thanks for the quick CLs!

Comment 8 by vapier@chromium.org, Aug 3 2017 

CLs are in flight, but the CQ has had a tummy ache the last day or two

Comment 9 by st...@chromium.org, Aug 3 2017 

Many thanks! A DEPS roll seems needed in chromium/src/DEPS as well.
We will land our CL after that.

Comment 10 by d...@chromium.org, Aug 3 2017 

RE #6, sorry if I implied any pressure. Basically stago@ identified this problem blocking their CL. They would like to land their CL, which applies to Chromium builds in general, of which CrOS-SDK-bootstrapped builds are a subset, but cannot until either this is fixed or add extra code to work around this problem. I was simply trying to get a feel for which option was better to satisfy their goal of landing their CL in the short term.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db

commit 7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db
Author: Yichun Li <yichunli@google.com>
Date: Thu Aug 03 22:16:46 2017

Run ninja wrapper only if recipe doesn't run cros-chrome-sdk wrapper

TBR=dpranke@chromium.org

Bug:  https://crbug.com/752212 
Change-Id: I9e44341b84f7d4177c01a0b0a65a503027dce332
Reviewed-on: https://chromium-review.googlesource.com/600807
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic__dbg_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_x64_dbg_try.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__clang_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic__dbg_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux_ASAN_mipsel___debug_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___beta_branch.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg__fail.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/cronet.expected/local_test.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN___concurrent_marking.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___verify_csa.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_release.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_fail.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium/tests/sizes.expected/platform.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64___debug_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/syzygy/coverage.expected/full_master_client_syzygy_win_cov_try.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___vtunejit.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_libfuzzer_clang_tot.expected/full_chromium_fyi_ClangToTLinuxASanLibfuzzer.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium/tests/compile.expected/official.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Mac_ASan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_UBSan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_ASAN___debug_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_ASAN_no_inline___release_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug_forced.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_release.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/syzygy/examples/full.expected/full_master_client_syzygy_Syzygy_Debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_compile_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_gcc_4_8___debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_official_try.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64___release_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch___debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___stable_branch.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_tsan_v2.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_CFI___release_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___nosnap___debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_with_custom_mb_config.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___concurrent_marking___builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium/tests/compile.expected/codesearch.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug__arm_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_clang__dbg_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux_fail.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__clang_.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android64_x64_debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_mips_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_asan.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Debug_x64.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/blink_linux.json
[modify] https://crrev.com/7cb1dfc43d6a8b08d805c6f8586af08d6f6a69db/scripts/slave/recipes/swarming/deterministic_build.expected/full_c
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c98f4561dc2203c62023db448a47c945a2ec5a1e

commit c98f4561dc2203c62023db448a47c945a2ec5a1e
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Aug 04 02:23:22 2017

Revert "Add basic OrderedDict fallback implementation."

This reverts commit c2a25b5428bacfa8bbaf89f858ace747f736bebb.

The fallback was added to support python 2.6 systems, but we no
longer have or care about python 2.6.  Back this out so we can
upgrade argparse to something newer.

BUG= chromium:219227 
BUG= chromium:752212 
TEST=precq doesn't go boom

Change-Id: I90ae6b3dc1673643807d64b0775c8d611ceaa617
Reviewed-on: https://chromium-review.googlesource.com/600608
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/c98f4561dc2203c62023db448a47c945a2ec5a1e/third_party/argparse.py
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7eff0f4dea7963ac2479474fa10b1d9ce8cdfccb

commit 7eff0f4dea7963ac2479474fa10b1d9ce8cdfccb
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Aug 05 14:14:07 2017

presubmit: tweak cros_workon syntax to work with newer versions

BUG= chromium:752212 
TEST=None

Change-Id: I842ec4a7f130bd942b01d0194f7f5ad7f4183009
Reviewed-on: https://chromium-review.googlesource.com/602629
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7eff0f4dea7963ac2479474fa10b1d9ce8cdfccb/site_utils/presubmit_hooks/check_control_files.py
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f4ce446cca4b90f2bcfff29834edd6ee9f1a5067

commit f4ce446cca4b90f2bcfff29834edd6ee9f1a5067
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Aug 06 05:07:54 2017

cros-workon: tweak cros_workon syntax to work with newer versions

BUG= chromium:752212 
TEST=None

Change-Id: Ieb389d7b35c2691acab175842a4e6ceaeb27bfe5
Reviewed-on: https://chromium-review.googlesource.com/602530
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/f4ce446cca4b90f2bcfff29834edd6ee9f1a5067/eclass/cros-workon.eclass
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/effb602b52eba0a47329bcd81affebbb7e2ba15d

commit effb602b52eba0a47329bcd81affebbb7e2ba15d
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Aug 06 05:07:52 2017

buffet: tweak cros_workon syntax to work with newer versions

BUG= chromium:752212 
TEST=None

Change-Id: I1ec8aa4f0b1ef6975bf9e070af46e132c32927ce
Reviewed-on: https://chromium-review.googlesource.com/602627
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/effb602b52eba0a47329bcd81affebbb7e2ba15d/buffet/HACKING
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1341bdda0ca67967c1fab21feef04606a789ea7d

commit 1341bdda0ca67967c1fab21feef04606a789ea7d
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Aug 06 16:49:20 2017

cros_workon: drop shared parser logic

We currently create a shared parser, attach it to the top parser (for
`cros_workon --xxx`), and then attach it to the sub-command parsers
(for `cros_workon foo --xxx`).  The name "shared" implies that there is
a single instance, but that is not the case -- it gets duplicated.  So
in effect, you have two independent flags with the same name that write
to the same location in the options namespace.

With newer argparse, this no longer works because of how defaults are
set.  If we look at something like `cros_workon --host list`, the new
logic processes the top level first (so sets opts.host=True), and then
processes the "list" subparser, and since --host wasn't passed in, it
sets opts.host=False (as the default).

Lets drop support for passing the common options to the subparsers.
If you want to pass in --board/etc..., they have to come first.  i.e.
`cros_workon list --board` no longer works.  Trying to support this
ourselves is going to be kind of a pita.  Lets see if anyone notices.

BUG= chromium:752212 
TEST=precq passes

Change-Id: I8d87a2cc5f0064803da5314b324dd137f6f32409
Reviewed-on: https://chromium-review.googlesource.com/602254
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/1341bdda0ca67967c1fab21feef04606a789ea7d/scripts/cros_workon.py
[modify] https://crrev.com/1341bdda0ca67967c1fab21feef04606a789ea7d/lib/commandline.py
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5afcdeda72df4d1ae066376ee7e4a42a4504b50a

commit 5afcdeda72df4d1ae066376ee7e4a42a4504b50a
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 08 05:18:52 2017

cros-workon: update example cros_workon message

There is no platform2 ebuild anymore, nor a sep shill git repo.

BUG= chromium:752212 
TEST=None

Change-Id: I475d01d0e3f6ef23b9c03a730ff0b0be75d9cd92
Reviewed-on: https://chromium-review.googlesource.com/604116
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/5afcdeda72df4d1ae066376ee7e4a42a4504b50a/eclass/cros-workon.eclass
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/849cc52301e91415301c3787f47e491d0b83a421

commit 849cc52301e91415301c3787f47e491d0b83a421
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 08 21:56:13 2017

argparse: import -- fix

Importing the latest version of argparse is breaking some of our
shared subparser logic, so grab the single -- fix that people want
from the upstream version.

BUG= chromium:752212 
TEST=precq passes

Change-Id: Iab6683e67bfbd77b573da61b0c9208a62c6fcc03
Reviewed-on: https://chromium-review.googlesource.com/604267
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/849cc52301e91415301c3787f47e491d0b83a421/third_party/argparse.py
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/425ff317ec6c3947475c341a94385f0e914ba0c8

commit 425ff317ec6c3947475c341a94385f0e914ba0c8
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 09 18:48:06 2017

image_to_live: re-order cros_workon args to work w/newer versions

BUG= chromium:752212 
TEST=None

Change-Id: Idaa12afdb08513df029df4c80d23fe6de7a5cc25
Reviewed-on: https://chromium-review.googlesource.com/607005
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/425ff317ec6c3947475c341a94385f0e914ba0c8/host/image_to_live.sh
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/efd6693ff912ebebc2e4eda1f438d664ed17c486

commit efd6693ff912ebebc2e4eda1f438d664ed17c486
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Aug 12 08:26:25 2017

commandline: make common options work w/newer subparsers & argparse

Newer argparse has changed how it processes defaults in relation to
subparsers and the user arguments.  Previously it was:
- Seed namespace with defaults from base parser.
- Update namespace with defaults from subparsers.
- Process user options with base parser and update namespace.
- Process user options with subparsers and update namespace.

Now it's more like:
- Seed namespace with defaults from base parser.
- Process user options with base parser and update namespace.
- Update namespace with defaults from subparsers.
- Process user options with subparsers and update namespace.

This ends up breaking all the common options we share between our base
parser and any subparsers.  For example, we add common logging options
to most of our scripts, and we repeat them with subsommands.  This way
you can run either form:
$ cros --nocolor --debug lint ...
$ cros lint --nocolor --debug ...

Hoist the default setup logic out of argparse and into our own hands for
all the common options.  Now argparse won't even see these defaults, so
we can apply the default options after processing all user options.

Throw in some tests too to make sure we aren't surprised again.

BUG= chromium:752212 
TEST=precq passes

Change-Id: I93797ec07d85c2ba1701929b915b498f88735a35
Reviewed-on: https://chromium-review.googlesource.com/604527
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/efd6693ff912ebebc2e4eda1f438d664ed17c486/lib/commandline_unittest.py
[modify] https://crrev.com/efd6693ff912ebebc2e4eda1f438d664ed17c486/lib/commandline.py
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/08a4e79116b86b970def106f5114ff49c03ddad9

commit 08a4e79116b86b970def106f5114ff49c03ddad9
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Aug 12 19:56:51 2017

argparse: update to current 2.7 version

BUG= chromium:752212 
TEST=precq passes
CQ-DEPEND=CL:604527

Change-Id: I82c41652e5b6caddc88300cd4d75d4c92938b596
Reviewed-on: https://chromium-review.googlesource.com/601009
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/08a4e79116b86b970def106f5114ff49c03ddad9/third_party/argparse.py

Comment 22 by vapier@chromium.org, Aug 12 2017

Status: Fixed (was: Started)
hopefully the fixes stick ;)
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8557a29af7621aef9c62d09b9b785865466ca7a0

commit 8557a29af7621aef9c62d09b9b785865466ca7a0
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 17 08:56:57 2017

cros_generate_sysroot: update help strings

Newer argparse doesn't like it when we put % sequences into the help
string directly as it tries to expand it.  Rework how we set up the
default to fix.

BUG= chromium:752212 
TEST=`cros_generate_sysroot --help` works again

Change-Id: I5fa8a431cf1df963fa04b055463c41ffb79d1328
Reviewed-on: https://chromium-review.googlesource.com/615464
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/8557a29af7621aef9c62d09b9b785865466ca7a0/scripts/cros_generate_sysroot.py
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1a21ea2beb970b2bfd1fa3d34f89aa4c8e0aaf6

commit d1a21ea2beb970b2bfd1fa3d34f89aa4c8e0aaf6
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 17 23:26:14 2017

roll chromite deps

BUG= chromium:752212 

Change-Id: I55a1094cb39c66afe5ba158b27bc96ff6d652c46
Reviewed-on: https://chromium-review.googlesource.com/607288
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495377}
[modify] https://crrev.com/d1a21ea2beb970b2bfd1fa3d34f89aa4c8e0aaf6/DEPS
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0b3d7bbaca7c34f2183c32df7620412291db1b87

commit 0b3d7bbaca7c34f2183c32df7620412291db1b87
Author: Shuotao Gao <stgao@chromium.org>
Date: Mon Aug 28 22:15:29 2017

[Ninja wrapper] Pass ninja path, source code dir and build output dir.

Two changes:
1. Pass ninja path, source code dir and build output dir to ninja wrapper script.
   The two dirs will be used to normalize the dependency file extracted from ninja deps/graph -- determine whether it is a checked-in file or a generated one, etc.
2. Use ninja wrapper for cros as  https://crbug.com/752212  is fixed.

Bug: 752250, 752256,  752212 
Change-Id: I8252a9960b80cc5cc1f21d6c0db1f5e66c496095
Reviewed-on: https://chromium-review.googlesource.com/622768
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic__dbg_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_x64_dbg_try.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__clang_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic__dbg_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux_ASAN_mipsel___debug_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___beta_branch.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg__fail.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/cronet.expected/local_test.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_UBSanVptr___release_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN___concurrent_marking.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___verify_csa.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_release.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_UBSan___release_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_fail.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium/tests/sizes.expected/platform.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64___debug_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/syzygy/coverage.expected/full_master_client_syzygy_win_cov_try.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___vtunejit.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_libfuzzer_clang_tot.expected/full_chromium_fyi_ClangToTLinuxASanLibfuzzer.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium/tests/compile.expected/official.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Mac_ASan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_UBSan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_ASAN___debug_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_ASAN_no_inline___release_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug_forced.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/staging.expected/android.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64_ASAN.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/syzygy/examples/full.expected/full_master_client_syzygy_Syzygy_Debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__msvc_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_compile_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_gcc_4_8___debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_official_try.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64___release_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch___debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___stable_branch.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_tsan_v2.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_CFI___release_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___nosnap___debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_with_custom_mb_config.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___concurrent_marking___builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium/tests/compile.expected/codesearch.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug__arm_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux_fail.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__clang_.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android64_x64_debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_mips_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty_test_output.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_asan.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json
[modify] https://crrev.com/0b3d7bbaca7c34f2183c32df7620412291db1b87/scripts/slave/recipes/webrtc/standalone.expected/tryserver_w
►

Sign in to add a comment