New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752209 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Android ACTION_NEXT_HTML_ELEMENT fails if accessibility focus is cleared

Project Member Reported by dmazz...@chromium.org, Aug 3 2017

Issue description

See internal bug b/63763952

TalkBack normally sends Chrome a ACTION_NEXT_HTML_ELEMENT action on the virtual view that has accessibility focus, and in that case everything works fine.

However, sometimes accessibility focus gets cleared before we receive the ACTION_NEXT_HTML_ELEMENT action, and in that case we're incorrectly exiting.

The user experience is that while swiping through a page, TalkBack will get "stuck" and then jump back up to the top.

We should be ignoring accessibility focus - since performAction is called on a virtual view, we can use that as the 'start node' and do the next html element from there, regardless of where accessibility focus is.

 
Labels: triage-dominic-android
Labels: -triage-dominic-android
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da890b60e5cd8841e29eef0a413af84f79e85e2

commit 6da890b60e5cd8841e29eef0a413af84f79e85e2
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Aug 14 20:14:57 2017

ACTION_NEXT_HTML_ELEMENT should ignore accessibility focus.

When we get a call to ACTION_NEXT_HTML_ELEMENT or
ACTION_PREVIOUS_HTML_ELEMENT, we should use the node that performAction
was called on as the start of the element search, rather than using
accessibility focus.

The vast majority of the time they're the same, which is why things
have been working, but occasionally we seem to get the performAction
call just after accessibility focus is cleared, possibly due to a
race condition.

Bug:  752209 
Change-Id: Ide55eb75ccb2da408ccde6b4edb02c9c3d1f3bca
Reviewed-on: https://chromium-review.googlesource.com/600739
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494160}
[modify] https://crrev.com/6da890b60e5cd8841e29eef0a413af84f79e85e2/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibility.java

Status: Fixed (was: Started)

Sign in to add a comment