New issue
Advanced search Search tips

Issue 752199 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT Import] Trailing whitespaces from upstream cause presubmit lint errors

Project Member Reported by robertma@chromium.org, Aug 3 2017

Issue description

A recent upstream change contains a trailing space in README.md:
https://github.com/w3c/web-platform-tests/commit/99f333d0822e6788e200b8fae3cb758be99211ff

which leads to presubmit check failures:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F417%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout


More detailed logs from local run:

Running presubmit commit checks ...
Running /usr/local/google/home/robertma/chromium/src/PRESUBMIT.py
Running /usr/local/google/home/robertma/chromium/src/third_party/PRESUBMIT.py
Running /usr/local/google/home/robertma/chromium/src/third_party/WebKit/PRESUBMIT.py
Running /usr/local/google/home/robertma/chromium/src/third_party/WebKit/LayoutTests/PRESUBMIT.py
Running /usr/local/google/home/robertma/chromium/src/third_party/WebKit/LayoutTests/external/PRESUBMIT.py
Running /usr/local/google/home/robertma/chromium/src/third_party/WebKit/Tools/PRESUBMIT.py

** Presubmit ERRORS **
README.md:18: Whitespace at EOL (TRAILING WHITESPACE)

There was 1 error (TRAILING WHITESPACE: 1)
You must fix all errors; for details on how to fix them, see
http://web-platform-tests.org/writing-tests/lint-tool.html

However, instead of fixing a particular error, it's sometimes
OK to add a line to the lint.whitelist file in the root of the
web-platform-tests directory to make the lint tool ignore it.

For example, to make the lint tool ignore all 'TRAILING WHITESPACE'
errors in the README.md file,
you could add the following line to the lint.whitelist file.

TRAILING WHITESPACE:README.md

 
If the upstream does not plan to add similar lint checks to Travis, I think we should at least ignore trailing white spaces in external/**.md (or probably all files?).
Cc: foolip@chromium.org jeffcarp@chromium.org
This presubmit error is from the wpt lint script, which is already run upstream (or at least, it should be?)

Looks like that commit bypassed Travis because it wasn't made via a pull request?
Labels: -Pri-3 Pri-1
Owner: qyears...@chromium.org
Status: Started (was: Untriaged)
This particular case is currently blocking importer.
Labels: -Pri-1 Pri-3
Status: Fixed (was: Started)
Not blocking now.

Filed issue https://github.com/w3c/web-platform-tests/issues/6776 for the general issue.

Sign in to add a comment