Issue metadata
Sign in to add a comment
|
5.2% regression in system_health.memory_mobile at 482763:483076 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8972264503584376240
,
Aug 3 2017
=== Auto-CCing suspected CL author verwaest@chromium.org === Hi verwaest@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Toon Verwaest Commit : e91c6dc7a9d3cdd37fc572f69625123b6564c0e0 Date : Tue Jun 27 12:25:22 2017 Subject: [dictionary] Move Name into PropertyCell to save space in overallocated hashtable Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/background_social/background_social_facebook Change : 5.49% | 4821352.0 -> 5085922.0 Revision Result N chromium@482762 4821352 +- 88498.1 6 good chromium@482841 4778823 +- 21089.5 9 good chromium@482861 4785841 +- 49667.3 9 good chromium@482864 4780778 +- 66755.8 14 good chromium@482864,v8@189c8263e5 4785321 +- 92492.6 21 good chromium@482864,v8@e91c6dc7a9 4825447 +- 293291 14 bad <-- chromium@482864,v8@8060b9cc45 4836416 +- 293304 9 bad chromium@482864,v8@095132d67a 4839510 +- 288586 9 bad chromium@482864,v8@ab028038db 4805392 +- 90130.0 14 bad chromium@482865 4936663 +- 443105 9 bad chromium@482866 5101711 +- 1495.0 6 bad chromium@482871 5101413 +- 1850.51 6 bad chromium@482880 5064954 +- 311736 9 bad chromium@482919 5101508 +- 1418.59 6 bad chromium@483076 5085922 +- 84143.5 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=background.social.facebook system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8972264503584376240 For feedback, file a bug with component Speed>Bisection
,
Aug 11 2017
,
Nov 2 2017
This CL actually reduces memory usage. Since the "average" tanks, I'm guess that using less memory causes fewer GCs. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 3 2017