New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752175 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 753584



Sign in to add a comment

add betty-chrome-pfq to the pfq

Project Member Reported by akes...@chromium.org, Aug 3 2017

Issue description

(+ jorgelo I don't know who pointed this out by VC yesterday (couldn't see) can you add them?)

Per discussion, since betty is our main supported vmtest-able board and is relied on in this way in the pre-cq and cq, it needs to be protected from breakage from chrome CLs.
 
Cc: steve...@chromium.org
Owner: akes...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8cdbe7786293142b6ee371245ad8e92b0c08fad1

commit 8cdbe7786293142b6ee371245ad8e92b0c08fad1
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Aug 04 02:23:18 2017

chromeos_config: add betty-chrome-pfq as experimental to chrome-pfq

BUG= chromium:752175 
TEST=None

Change-Id: Ia1316b429b7705b9ffae153196cfd328028afb0d
Reviewed-on: https://chromium-review.googlesource.com/600628
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/8cdbe7786293142b6ee371245ad8e92b0c08fad1/cbuildbot/config_dump.json
[modify] https://crrev.com/8cdbe7786293142b6ee371245ad8e92b0c08fad1/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/8cdbe7786293142b6ee371245ad8e92b0c08fad1/cbuildbot/chromeos_config.py

Cc: yusukes@chromium.org
Yusuke landed the Chrome CL that this would have prevented.
Next step: await waterfall restart; wait for this new builder to go green; mark as important.
Blockedon: 753584
akeshet@, could you let me know which tests betty-chrome-pfq actually runs?

Last time I landed the Chrome patch (crrev.com/485192), login_OwnershipApi, security_ASLR, and platform_FilePerms started failing on the Chrome OS Pre-CQ side. Are these tests part of the pfq? What about cheets_* auto tests?

It's not running yet, but when it is it will run the same (or a superset perhaps) of the tests that are in the cq.
Cc: jdufault@chromium.org
The builder now exists. It is failing due to an existing problem in security_NetworkListeners.

After it goes green, can be marked as important.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/60ae7c10fc439de40636847991523e9c28318853

commit 60ae7c10fc439de40636847991523e9c28318853
Author: Aviv Keshet <akeshet@chromium.org>
Date: Mon Aug 14 21:57:29 2017

chromeos_config: mark betty-chrome-pfq as important

BUG= chromium:752175 
TEST=None

Change-Id: I94ba8e934bd7ec9f15ada18ca73dfd7c61aac940
Reviewed-on: https://chromium-review.googlesource.com/612490
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>

[modify] https://crrev.com/60ae7c10fc439de40636847991523e9c28318853/cbuildbot/config_dump.json
[modify] https://crrev.com/60ae7c10fc439de40636847991523e9c28318853/cbuildbot/chromeos_config.py

Status: Fixed (was: Started)
Thanks a lot!

Sign in to add a comment