New issue
Advanced search Search tips

Issue 752172 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 759519
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.1%-1.3% regression in system_health.memory_desktop at 488900:488956

Project Member Reported by ulan@google.com, Aug 3 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=752172

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0017086f576e7db7eb3474d73c24366dcbfef60313bcfd262c252f6ccac9cbe4


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
chromium-rel-win7-x64-dual
win-high-dpi
Cc: ricea@chromium.org
Owner: ricea@chromium.org

=== Auto-CCing suspected CL author ricea@chromium.org ===

Hi ricea@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Adam Rice
  Commit : a3bdaf8ef960c95c2f7836bebe0be476d0d1e2fa
  Date   : Mon Jul 24 08:49:54 2017
  Subject: Streams API: Harden SimpleQueue

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_games/load_games_lazors
  Change       : 1.57% | 3000048.0 -> 3047062.66667

Revision             Result                 N
chromium@488904      3000048 +- 0.0         6      good
chromium@488930      3000048 +- 0.0         6      good
chromium@488931      3000048 +- 0.0         6      good
chromium@488932      3034536 +- 0.0         6      bad       <--
chromium@488934      3034536 +- 0.0         6      bad
chromium@488937      3034536 +- 0.0         6      bad
chromium@488943      3034800 +- 0.0         6      bad
chromium@488956      3047063 +- 124.15      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.lazors system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8972264747284869856


For feedback, file a bug with component Speed>Bisection

Comment 4 by ricea@chromium.org, Aug 4 2017

Components: Blink>Network>StreamsAPI
Same sort of thing as  issue 748279  and  issue 708550 . Changes to the Streams implementation change the size of the v8 heap.

Comment 5 by ricea@chromium.org, Aug 28 2017

Mergedinto: 759519
Status: Duplicate (was: Assigned)

Sign in to add a comment