New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752166 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Clicking launcher button doesn't work on secondary monitor

Project Member Reported by tbuck...@chromium.org, Aug 3 2017

Issue description

Chrome Version: 61.0.3163.20 (Official Build) dev (64-bit)
OS: Chrome

What steps will reproduce the problem?
(1) Connect an external monitor to a Caroline
(2) Make the external monitor the primary monitor in Display Settings
(3) Click the launcher button on Caroline's built-in monitor

What is the expected result?
Launcher opens on the secondary monitor

What happens instead?
There's a black flash, and it appears as though the Launcher appears off-screen.
 
Cc: vadimt@chromium.org robertrtung@chromium.org
Owner: newcomer@chromium.org
I am also getting an unintended result (though possibly a bit different from yours).

When I do these steps the first click of the launcher button does nothing and then on the second click the launcher appears on a small subset of the external display (screenshot attached).

Moreover if instead of step (3), I click the launcher button on the external display, the first click again does nothing, and on the second click the launcher flashes really quickly on the internal display and then disappears.

I also reproduced this on a Link and on 61.0.3163.13 dev so the bug is likely a Launcher-related bug that was introduced at / before that build. Passing this on to Alex and CC-ing Vadim
Screenshot 2017-08-03 at 9.40.29 AM - Display 1.png
1.9 MB View Download
Cc: -robertrtung@chromium.org newcomer@chromium.org
Owner: weidongg@chromium.org
Cc: minch@chromium.org weidongg@chromium.org maajid@chromium.org
 Issue 740617  has been merged into this issue.
 Issue 754450  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b5364ee619ec0aa24c7dbc087652c331b09769

commit c9b5364ee619ec0aa24c7dbc087652c331b09769
Author: Weidong Guo <weidongg@chromium.org>
Date: Sat Aug 12 01:19:15 2017

Support fullscreen app list in extended monitor

Changes:
1. Use Window::SetBoundsInScreen and Window::SetBounds instead of
Widget::SetBounds which smartly show the widget only in the display
where it has the largest intersection.
2. Unify all points and rectangles in drag to using screen coordinates
to avoid weird movement in extended monitor.
3. Reset the initial drag point only when we are not in drag.

BUG= 752166 

Change-Id: Ic42107991ec3007a640f851396f6a68fcbf142c3
Reviewed-on: https://chromium-review.googlesource.com/610889
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493925}
[modify] https://crrev.com/c9b5364ee619ec0aa24c7dbc087652c331b09769/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/c9b5364ee619ec0aa24c7dbc087652c331b09769/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/c9b5364ee619ec0aa24c7dbc087652c331b09769/ui/app_list/views/app_list_view.h

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5f7f5a7f8b099c385bfe00bffa469f46f98adc0

commit e5f7f5a7f8b099c385bfe00bffa469f46f98adc0
Author: Maajid <maajid@chromium.org>
Date: Thu Aug 17 01:12:20 2017

Support fullscreen app list in extended monitor

Changes:
1. Use Window::SetBoundsInScreen and Window::SetBounds instead of
Widget::SetBounds which smartly show the widget only in the display
where it has the largest intersection.
2. Unify all points and rectangles in drag to using screen coordinates
to avoid weird movement in extended monitor.
3. Reset the initial drag point only when we are not in drag.

BUG= 752166 
TBR=weidongg@chromium.org

(cherry picked from commit c9b5364ee619ec0aa24c7dbc087652c331b09769)

Change-Id: Ic42107991ec3007a640f851396f6a68fcbf142c3
Reviewed-on: https://chromium-review.googlesource.com/610889
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493925}
Reviewed-on: https://chromium-review.googlesource.com/618400
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#622}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e5f7f5a7f8b099c385bfe00bffa469f46f98adc0/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/e5f7f5a7f8b099c385bfe00bffa469f46f98adc0/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/e5f7f5a7f8b099c385bfe00bffa469f46f98adc0/ui/app_list/views/app_list_view.h

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment