New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752145 link

Starred by 4 users

[Play Review Stable] Chrome crash when click link in email

Project Member Reported by hongchic...@chromium.org, Aug 3 2017

Issue description

Chrome Version: 60.0.3112.78
OS: Android

Filing a new bug to track this issue which we've been seeing since M58 (old bug:  crbug.com/727386 )

Issue description:
Chrome custom tab crashes when users click link from other app such as gmail.
We are reaching out to users to learn more context

http://feedback/#/Report/69817041859
http://feedback/#/Report/69809674527
https://listnr.corp.google.com/report/69723038855
https://listnr.corp.google.com/report/69777072589



What is the expected result?

What happens instead?

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Cc: prashanthpola@chromium.org
Labels: triage-te
prashanthpola@, can you try to repro?

Comment 2 by k...@chromium.org, Aug 7 2017

Cc: sbirch@chromium.org
+sbirch as heads up on potential CCT issue
we're seeing more reports from Play review. Please see attached screenshots. 
Screen Shot 2017-08-07 at 1.34.31 PM.png
106 KB View Download
Screen Shot 2017-08-07 at 1.34.46 PM.png
97.3 KB View Download
Screen Shot 2017-08-07 at 1.35.05 PM.png
80.0 KB View Download
Components: UI>Browser>Mobile>CustomTabs
Labels: -Pri-3 Pri-1
Owner: yus...@chromium.org
Status: Assigned (was: Untriaged)
I am not sure if its the same bug as the users are reporting. As I see Chrome crash after I try to re-access Gmail/ CCT tab once Chrome is closed.

Steps:
1. Set the device language to Japanese
2. Upgraded Chrome to M60 
3. Launch latest Gmail app -> Open an email -> tap on any link in the email -> Opens in CCT
4. From Menu choose to open in browser (Chrome)
5. Go to Android recents
6. Close Chrome from there
7. Tap on 'Gmail' app from recents

Observe:
Chrome crashes

Notes:
* I see this crash whenever a CCT is open and I close Chrome from recents.
* I could repro it even after changing the device language to English
* i was not able to repro this same issue on a Pixel XL / 7.1.2. Seems device/ OS specific.
* Most of the reports are from 4.4 (K).

Please find logs and demo @ http://go/chrome-androidlogs1/7/752145 

yusufo@ Can PTL and re-assign as needed?
I forgot to mention the device used earlier.
I could repro it on a Sony Xperia Z1 (SOL23)/4.4.2 .
Cc: lizeb@chromium.org
Adding lizeb@ in case this sounds like something to relate to in latest patches.

Do we not have a crash stack?
Never mind, just noticed the logs, sorry.

FATAL EXCEPTION: main
08-07 21:48:14.488 E/AndroidRuntime(22936): Process: com.android.chrome, PID: 22936
08-07 21:48:14.488 E/AndroidRuntime(22936): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.android.chrome/org.chromium.chrome.browser.customtabs.CustomTabActivity}: java.lang.NullPointerException
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2248)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2298)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.ActivityThread.access$800(ActivityThread.java:144)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1246)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.os.Handler.dispatchMessage(Handler.java:102)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.os.Looper.loop(Looper.java:212)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.ActivityThread.main(ActivityThread.java:5151)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at java.lang.reflect.Method.invokeNative(Native Method)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at java.lang.reflect.Method.invoke(Method.java:515)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:877)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:693)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at dalvik.system.NativeStart.main(Native Method)
08-07 21:48:14.488 E/AndroidRuntime(22936): Caused by: java.lang.NullPointerException
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at org.chromium.chrome.browser.firstrun.ToSAckedReceiver.checkAnyUserHasSeenToS$51662RJ4E9NMIP1FCDNMST35DPQ2UGRFDPQ6AU3K7CKLK___0(ToSAckedReceiver.java:19)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer.checkIfFirstRunIsNecessary(FirstRunFlowSequencer.java:14)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer.launch(FirstRunFlowSequencer.java:41)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at org.chromium.chrome.browser.init.AsyncInitializationActivity.onCreate(AsyncInitializationActivity.java:89)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.Activity.performCreate(Activity.java:5231)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2212)
08-07 21:48:14.488 E/AndroidRuntime(22936): 	... 11 more
08-07 21:48:14.638 W/ActivityManager( 1021):   Force finishing activity com.android.chrome/org.chromium.chrome.browser.customtabs.CustomTabActivity
08-07 21:48:14.728 I/CrashMonitor(21332): CrashMonitorServiceBroadcastReceiver: Forwarding intent: android.intent.action.DROPBOX_ENTRY_ADDED tag: system_app_crash


Seems like first run related, I will try to triage and see if we can relate with any recent changes.
Cc: hongchic...@chromium.org
 Issue 753638  has been merged into this issue.
Labels: ReleaseBlock-Stable
This is marginally implicated in  issue 755484  so marking this (and that bug) as a stable blocker.
Ya, this has a similar stack we're just trying to launch a different activity but all activity launches go through this one choke point so they could be failing in a similar way
It almost looks like we haven't run ContextUtils.initApplicationContext because we're getting an NPE in 
org.chromium.chrome.browser.firstrun.ToSAckedReceiver.checkAnyUserHasSeenToS$51662RJ4E9NMIP1FCDNMST35DPQ2UGRFDPQ6AU3K7CKLK___0(ToSAckedReceiver.java:19)


which seems like garbage but could be an artifact of the lazy holder + static shared preferences code? I'm kind of reaching here but the stack line numbers make no sense
Labels: M-60
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eb42e3c1b4b2b63436970e2f646b7a055088b8c

commit 4eb42e3c1b4b2b63436970e2f646b7a055088b8c
Author: Ted Choc <tedchoc@google.com>
Date: Tue Aug 15 23:46:20 2017

Fix ToSAckedReceiver after AccountManager refactoring.

All the necessary dependencies were not initialized when interacting
with the ToSAckedReceiver, which caused crashes during startup.

BUG= 752145 

Change-Id: I6f0c92dcaa0ddec8b55adf634143f3aa6a6d999e
Reviewed-on: https://chromium-review.googlesource.com/616113
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494609}
[modify] https://crrev.com/4eb42e3c1b4b2b63436970e2f646b7a055088b8c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAckedReceiver.java
[modify] https://crrev.com/4eb42e3c1b4b2b63436970e2f646b7a055088b8c/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/4eb42e3c1b4b2b63436970e2f646b7a055088b8c/chrome/android/java_sources.gni
[add] https://crrev.com/4eb42e3c1b4b2b63436970e2f646b7a055088b8c/chrome/android/junit/src/org/chromium/chrome/browser/firstrun/ToSAckedReceiverTest.java

Labels: Merge-Request-61 Merge-Request-60
Project Member

Comment 16 by sheriffbot@chromium.org, Aug 15 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Request-60 -Merge-Review-61 Merge-Approved-60 Merge-Approved-61
Merge approved for M60 branch 3112 and M61 branch 3163.  Please also merge to branch 3187 ASAP so I can kick a daily build and we can ensure it goes out before EOD to get coverage.
Cc: nyquist@chromium.org ranj@chromium.org amineer@chromium.org tedc...@chromium.org bsazonov@chromium.org yfried...@chromium.org
 Issue 755484  has been merged into this issue.
For anyone seeing this later, please note  issue 755484  has a *lot* of context about this issue and the fix in c#14.
Cc: yus...@chromium.org
Owner: tedc...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 16 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31fd091ece2f5916466c2cfc0b38aa16bf03b9b3

commit 31fd091ece2f5916466c2cfc0b38aa16bf03b9b3
Author: Ted Choc <tedchoc@google.com>
Date: Wed Aug 16 21:22:33 2017

Fix ToSAckedReceiver after AccountManager refactoring.

All the necessary dependencies were not initialized when interacting
with the ToSAckedReceiver, which caused crashes during startup.

BUG= 752145 

Change-Id: I6f0c92dcaa0ddec8b55adf634143f3aa6a6d999e
Reviewed-on: https://chromium-review.googlesource.com/616113
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494609}
Reviewed-on: https://chromium-review.googlesource.com/617466
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#608}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/31fd091ece2f5916466c2cfc0b38aa16bf03b9b3/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAckedReceiver.java

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 16 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63fa43cf64dc971070a48310faaa65c26f4b6314

commit 63fa43cf64dc971070a48310faaa65c26f4b6314
Author: Ted Choc <tedchoc@google.com>
Date: Wed Aug 16 22:05:44 2017

Fix ToSAckedReceiver after AccountManager refactoring.

All the necessary dependencies were not initialized when interacting
with the ToSAckedReceiver, which caused crashes during startup.

BUG= 752145 

Change-Id: I6f0c92dcaa0ddec8b55adf634143f3aa6a6d999e
Reviewed-on: https://chromium-review.googlesource.com/616113
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#494609}
Reviewed-on: https://chromium-review.googlesource.com/617466
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3163@{#608}
Cr-Original-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
Reviewed-on: https://chromium-review.googlesource.com/617814
Cr-Commit-Position: refs/branch-heads/3112@{#732}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/63fa43cf64dc971070a48310faaa65c26f4b6314/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAckedReceiver.java

Status: Fixed (was: Started)
Crossing fingers so hard and marking this as fixed.  tedchoc@, reopen if you think there's more follow up that's required here - and thanks again for the fix.
On Sony Xperia Z1 (SOL23)/ 4.4.2 , I got Chrome 60.0.3112.97 to crash when opening links from Gmail and then upgraded to 60.0.3112.107 and it did NOT crash anymore. The external intent case crash can be said verified. Thanks!

Sign in to add a comment