New issue
Advanced search Search tips

Issue 752139 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

WebVR: Stop relying on content to determine whether an origin is secure.

Project Member Reported by mthiesse@chromium.org, Aug 3 2017

Issue description

We shouldn't trust content to tell us whether it's secure, we should determine this browser-side.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd2d407090eb652fda83c51ff76652e7adbc1ba4

commit cd2d407090eb652fda83c51ff76652e7adbc1ba4
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Aug 09 18:10:04 2017

WebVR: Read secure origin state in browser

This moves the checking of the secure origin state to the trusted
browser process, out of the untrusted renderer process.

Bug:  752139 
Change-Id: Ic3da7a0bfa3f7c38102f6e63512dc963711bd71e
Reviewed-on: https://chromium-review.googlesource.com/600491
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493053}
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/openvr/openvr_device.h
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/test/fake_vr_device.h
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/vr_device.h
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/vr_display_impl.cc
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/vr_display_impl.h
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/device/vr/vr_service.mojom
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/cd2d407090eb652fda83c51ff76652e7adbc1ba4/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Status: Fixed (was: Started)
 Issue 735760  has been merged into this issue.
Components: Blink>WebXR

Sign in to add a comment