The list of cookies is cached between visits to chrome://settings/content/cookies |
|||
Issue descriptionWhat steps will reproduce the problem? (1) go to chrome://settings/content/cookies (2) open a new tab and visit some website that creates cookies (3) go to settings tab and go back to content settings and then to cookies again What is the expected result? The cookie page should show an up to date list of cookies. What happens instead? The cookies page doesn't show newer entries because the CookiesTreeModel is cached from the first visit. The same problem exists when using Clear Browsing Data without reloading settings afterwards. Should the cookies page call reloadCookies() when it is visited again?
,
Aug 9 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18f10a6e98203ee1e19e192853f93b9742586531 commit 18f10a6e98203ee1e19e192853f93b9742586531 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Aug 24 10:36:28 2017 Reload cookies when cookie page is visited Cookies are only loaded on first visit. This is confusing if you expect cookies to have changed e.g. by visiting a website or using ClearBrowsingData. This CL fixes the issue by reloading cookies when the cookie page is visited. A bug in route.js is fixed where a RouteObserver, that is added during a navigation, might be notified twice about this navigation. Bug: 752133 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I601fef5a9771a296a1b2a7566d812e5beded3bb8 Reviewed-on: https://chromium-review.googlesource.com/607874 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#496997} [modify] https://crrev.com/18f10a6e98203ee1e19e192853f93b9742586531/chrome/browser/resources/settings/route.js [modify] https://crrev.com/18f10a6e98203ee1e19e192853f93b9742586531/chrome/browser/resources/settings/site_settings/site_data.js
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6be9a51ed0952e14c9ddddde05d44dbad010223 commit f6be9a51ed0952e14c9ddddde05d44dbad010223 Author: Tim Schumann <tschumann@chromium.org> Date: Thu Aug 24 12:40:48 2017 Revert "Reload cookies when cookie page is visited" Breaks the Asan tests: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F23228%2F%2B%2Frecipes%2Fsteps%2Fash_unittests%2F0%2Fstdout This reverts commit 18f10a6e98203ee1e19e192853f93b9742586531. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reload cookies when cookie page is visited > > Cookies are only loaded on first visit. This is confusing if you expect > cookies to have changed e.g. by visiting a website or using > ClearBrowsingData. This CL fixes the issue by reloading cookies when > the cookie page is visited. > > A bug in route.js is fixed where a RouteObserver, that is added during > a navigation, might be notified twice about this navigation. > > Bug: 752133 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I601fef5a9771a296a1b2a7566d812e5beded3bb8 > Reviewed-on: https://chromium-review.googlesource.com/607874 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496997} TBR=michaelpg@chromium.org,tommycli@chromium.org,dpapad@chromium.org,dullweber@chromium.org Change-Id: Ie0753efaf6177c4e0ef923c61a065b9944bf713c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752133 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/632097 Reviewed-by: Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#497014} [modify] https://crrev.com/f6be9a51ed0952e14c9ddddde05d44dbad010223/chrome/browser/resources/settings/route.js [modify] https://crrev.com/f6be9a51ed0952e14c9ddddde05d44dbad010223/chrome/browser/resources/settings/site_settings/site_data.js
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d545bbc7da3096a49138155c23a23675028becc0 commit d545bbc7da3096a49138155c23a23675028becc0 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Aug 24 13:00:48 2017 Revert "Revert "Reload cookies when cookie page is visited"" This reverts commit f6be9a51ed0952e14c9ddddde05d44dbad010223. Reason for revert: Check how this can cause a memory leak and reland Original change's description: > Revert "Reload cookies when cookie page is visited" > > Breaks the Asan tests: > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F23228%2F%2B%2Frecipes%2Fsteps%2Fash_unittests%2F0%2Fstdout > > This reverts commit 18f10a6e98203ee1e19e192853f93b9742586531. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reload cookies when cookie page is visited > > > > Cookies are only loaded on first visit. This is confusing if you expect > > cookies to have changed e.g. by visiting a website or using > > ClearBrowsingData. This CL fixes the issue by reloading cookies when > > the cookie page is visited. > > > > A bug in route.js is fixed where a RouteObserver, that is added during > > a navigation, might be notified twice about this navigation. > > > > Bug: 752133 > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > > Change-Id: I601fef5a9771a296a1b2a7566d812e5beded3bb8 > > Reviewed-on: https://chromium-review.googlesource.com/607874 > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#496997} > > TBR=michaelpg@chromium.org,tommycli@chromium.org,dpapad@chromium.org,dullweber@chromium.org > > Change-Id: Ie0753efaf6177c4e0ef923c61a065b9944bf713c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 752133 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/632097 > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#497014} TBR=michaelpg@chromium.org,tommycli@chromium.org,dpapad@chromium.org,tschumann@chromium.org,dullweber@chromium.org Change-Id: If9ad11d5294cb16118f6f6ebcf5f171601f875f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752133 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/632177 Reviewed-by: Tim Schumann <tschumann@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#497018} [modify] https://crrev.com/d545bbc7da3096a49138155c23a23675028becc0/chrome/browser/resources/settings/route.js [modify] https://crrev.com/d545bbc7da3096a49138155c23a23675028becc0/chrome/browser/resources/settings/site_settings/site_data.js
,
Aug 25 2017
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd4cb59466c7a1e779c0c2e267762974d0023218 commit dd4cb59466c7a1e779c0c2e267762974d0023218 Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Oct 04 13:15:15 2017 Restore cookie reloading Reloading data when the site data page is visited was added in https://crrev.com/c/607874 but the change got lost in https://crrev.com/c/640152. This CL restores the code to reload cookies. Bug: 752133 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3e1ffa886d52657917ebc43050476c7308234fc6 Reviewed-on: https://chromium-review.googlesource.com/684299 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#506374} [modify] https://crrev.com/dd4cb59466c7a1e779c0c2e267762974d0023218/chrome/browser/resources/settings/site_settings/site_data.js [modify] https://crrev.com/dd4cb59466c7a1e779c0c2e267762974d0023218/chrome/test/data/webui/settings/site_data_test.js [modify] https://crrev.com/dd4cb59466c7a1e779c0c2e267762974d0023218/chrome/test/data/webui/settings/test_local_data_browser_proxy.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by dullweber@chromium.org
, Aug 9 2017Status: Started (was: Untriaged)