Grammar issue in Mixed Content message: "that" vs. "which"
Reported by
mbrund...@gmail.com,
Aug 3 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36 Steps to reproduce the problem: 1. Navigate to a secure page that contains a form that targets an insecure endpoint. Example: https://www.faa.gov/ 2. Read the Mixed Content message in the console. What is the expected behavior? The message should read "... but contains a form that targets an insecure endpoint ..." What went wrong? The message incorrectly reads "... but contains a form which targets an insecure endpoint ..." "That" is the correct word to use here, as the clause is restrictive. Did this work before? No Chrome version: 60.0.3112.90 Channel: stable OS Version: 10.0 Flash Version:
,
Aug 4 2017
,
Aug 4 2017
Daniel, this is a great opportunity for you to learn how the commit queue works. :)
,
Aug 4 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a5b373dc09c2d8667a744df0deacdefaae17a2d commit 8a5b373dc09c2d8667a744df0deacdefaae17a2d Author: Daniel Hausknecht <dhausknecht@google.com> Date: Fri Aug 04 10:21:16 2017 correted "which" to "that" Bug: 752132 Change-Id: Ib7320e6156978e6eabe527dedc013609bffedfe9 Reviewed-on: https://chromium-review.googlesource.com/601791 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Daniel Hausknecht <dhausknecht@google.com> Cr-Commit-Position: refs/heads/master@{#491986} [modify] https://crrev.com/8a5b373dc09c2d8667a744df0deacdefaae17a2d/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-allowed-expected.txt [modify] https://crrev.com/8a5b373dc09c2d8667a744df0deacdefaae17a2d/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked-expected.txt [modify] https://crrev.com/8a5b373dc09c2d8667a744df0deacdefaae17a2d/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-expected.txt [modify] https://crrev.com/8a5b373dc09c2d8667a744df0deacdefaae17a2d/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp
,
Nov 10 2017
,
Nov 16 2017
This was fixed but not closed, marking as fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by eostroukhov@chromium.org
, Aug 3 2017