New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752130 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

[NTP Tiles] Investigate potential for showing real icons in NTP tiles based on 32px icons.

Project Member Reported by jkrcal@chromium.org, Aug 3 2017

Issue description

The current limit on Android is 48px. We display a lot (currently around 25%) of tiles as colored "scrabble" tiles. If we decreased the limit to 32px, 1/3 of these impressions should get displayed as real icons.

Based on current data, this could lead to +2.2% clicks from NTP Tiles.

We should investigate this possibility.
 
Labels: M-62 zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654

commit 7fadbd3bad722eebddbca59fe1a3a61a2c5dc654
Author: Jan Krcal <jkrcal@chromium.org>
Date: Fri Aug 04 10:49:21 2017

[NTP Tiles] Feature to decrease the limit for showing real icons to 32px

This is an experimental feature to show also lower-resolution favicons
in NTP tiles. This implementation serves for decision-making.

Bug:  752130 
Change-Id: I4d09ede341fb63c49845f6aac8b5b547b4473db1
Reviewed-on: https://chromium-review.googlesource.com/600236
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491989}
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileRenderer.java
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/chrome/browser/about_flags.cc
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/components/ntp_tiles/constants.cc
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/components/ntp_tiles/constants.h
[modify] https://crrev.com/7fadbd3bad722eebddbca59fe1a3a61a2c5dc654/tools/metrics/histograms/enums.xml

Comment 3 by fi...@chromium.org, Sep 18 2017

What's the current status? I'm just pinging it because it's targeted towards M-62.

Comment 4 by jkrcal@chromium.org, Sep 18 2017

Labels: -M-62 M-63
Code is done. Waiting for UX decision-making. 

Since it was not enabled on M62 Canary/Dev, M63 is the earliest milestone we can roll this out to.
Did this happen for M63?

Comment 6 by jkrcal@chromium.org, Oct 24 2017

No decision taken, yet. It is on my radar.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02b4c791a78387c68857e707a0cf94491e79ce19

commit 02b4c791a78387c68857e707a0cf94491e79ce19
Author: Jan Krcal <jkrcal@chromium.org>
Date: Wed Nov 15 19:25:18 2017

[Ntp Tiles] Decrease the threshold for real icons to 24px in Modern

This CL changes the threshold for showing real favicons (instead of
"scrabble" tiles) for NTP Tiles in Chrome Modern UI. In Modern, the
icons take half of the space as before (24dp). After this change, the
threshold is 24px, also half of the previous non-Modern value.

The previously used feature NTP_TILES_LOWER_RESOLUTION_FAVICONS is not
needed anymore and will be removed by a follow-up CL.

Bug:  752130 
Change-Id: I07938a7c040603fd12a262b3a034b7c42b45d3aa
Reviewed-on: https://chromium-review.googlesource.com/768691
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516779}
[modify] https://crrev.com/02b4c791a78387c68857e707a0cf94491e79ce19/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileRenderer.java
[modify] https://crrev.com/02b4c791a78387c68857e707a0cf94491e79ce19/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/434efb5769ad946aae17778f4121cd5306962a22

commit 434efb5769ad946aae17778f4121cd5306962a22
Author: Jan Krcal <jkrcal@chromium.org>
Date: Thu Nov 16 00:02:32 2017

[Ntp Tiles] Remove an experiment NTPTilesLowerResolutionFavicons

This CL removes an experimental feature and a corresponding flag from
chrome://flags. The removed feature was not needed any more because
the behaviour is now enabled by default if ChromeHome is enabled.

Bug:  752130 
Change-Id: I6b51a14ce7560cb16b54f5e6b6ba71e0f87f97d3
Reviewed-on: https://chromium-review.googlesource.com/769248
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516904}
[modify] https://crrev.com/434efb5769ad946aae17778f4121cd5306962a22/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/434efb5769ad946aae17778f4121cd5306962a22/chrome/browser/about_flags.cc
[modify] https://crrev.com/434efb5769ad946aae17778f4121cd5306962a22/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/434efb5769ad946aae17778f4121cd5306962a22/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/434efb5769ad946aae17778f4121cd5306962a22/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/434efb5769ad946aae17778f4121cd5306962a22/components/ntp_tiles/constants.cc
[modify] https://crrev.com/434efb5769ad946aae17778f4121cd5306962a22/components/ntp_tiles/constants.h

Comment 9 by jkrcal@chromium.org, Nov 20 2017

Status: Fixed (was: Started)

Sign in to add a comment