New issue
Advanced search Search tips

Issue 752122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Update Chromium to the most recent libaddressinput

Project Member Reported by se...@chromium.org, Aug 3 2017

Issue description

Most notable changes include:

Ability to normalize in a language that is different from the Chromium
language.

Ex: Chrome is in en-ca, user state is Nouveau-Brunswick.
Before: It could not normalize
After: Will normalize to NB

Removal of the const bool return type that Chromium didn't like. Which will allow us to validate countries.

 

Comment 1 Deleted

Comment 2 by se...@chromium.org, Aug 3 2017

Summary: Update Chromium to the most recent libaddressinput (was: Update Chrome to the most recent libaddressinput)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/260cd28a6f68f8b6bdda8a98c9483a738d23e741

commit 260cd28a6f68f8b6bdda8a98c9483a738d23e741
Author: sebsg <sebsg@chromium.org>
Date: Thu Aug 03 15:58:21 2017

Update the DEPS to use the most recent libaddressinput version.

Bug:  752122 
Change-Id: I90870a875855161b49e03bd1b4e7870f76dec694
Reviewed-on: https://chromium-review.googlesource.com/600289
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491754}
[modify] https://crrev.com/260cd28a6f68f8b6bdda8a98c9483a738d23e741/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba95fcbd9d01b1a5a929fd073147aa87d86f53fc

commit ba95fcbd9d01b1a5a929fd073147aa87d86f53fc
Author: Luna Lu <loonybear@chromium.org>
Date: Thu Aug 03 19:04:45 2017

Revert "Update the DEPS to use the most recent libaddressinput version."

This reverts commit 260cd28a6f68f8b6bdda8a98c9483a738d23e741.

Reason for revert: suspect causing the failure on https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62043

Original change's description:
> Update the DEPS to use the most recent libaddressinput version.
> 
> Bug:  752122 
> Change-Id: I90870a875855161b49e03bd1b4e7870f76dec694
> Reviewed-on: https://chromium-review.googlesource.com/600289
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491754}

TBR=mathp@chromium.org,sebsg@chromium.org

Change-Id: I642f76aa363a09951b64788615908ae4e618584e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  752122 
Reviewed-on: https://chromium-review.googlesource.com/600635
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491811}
[modify] https://crrev.com/ba95fcbd9d01b1a5a929fd073147aa87d86f53fc/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2567bc989e0fa27e0b6177a8515b7bd4e6d7d0ff

commit 2567bc989e0fa27e0b6177a8515b7bd4e6d7d0ff
Author: Sebastien SG <sebsg@chromium.org>
Date: Wed Aug 23 01:12:17 2017

Update the DEPS to use the most recent libaddressinput version.

Now that the Win7 bug is fixed upstream, Chromium can link to the most
recent version of libaddressinput.

Bug:  752122 
Change-Id: I58be37ba5b1aeb0fca6d9c9a7e0cfc622c37a7f8
Reviewed-on: https://chromium-review.googlesource.com/627102
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496537}
[modify] https://crrev.com/2567bc989e0fa27e0b6177a8515b7bd4e6d7d0ff/DEPS

Comment 6 by se...@chromium.org, Aug 24 2017

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afa96c8c68c50c32e3216f019ed9cab0edffb888

commit afa96c8c68c50c32e3216f019ed9cab0edffb888
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Aug 28 18:08:39 2017

Revert "Update the DEPS to use the most recent libaddressinput version."

This reverts commit 2567bc989e0fa27e0b6177a8515b7bd4e6d7d0ff.

Reason for revert: Broke address normalization for addresses
in India. See  https://crbug.com/759597 .

Original change's description:
> Update the DEPS to use the most recent libaddressinput version.
> 
> Now that the Win7 bug is fixed upstream, Chromium can link to the most
> recent version of libaddressinput.
> 
> Bug:  752122 
> Change-Id: I58be37ba5b1aeb0fca6d9c9a7e0cfc622c37a7f8
> Reviewed-on: https://chromium-review.googlesource.com/627102
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496537}

TBR=tmartino@chromium.org,sebsg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=sebsg@chromium.org

Bug:  752122 ,  759597 
Change-Id: I77b234b244ec69a670ed06051461c018840c7a58
Reviewed-on: https://chromium-review.googlesource.com/638670
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497805}
[modify] https://crrev.com/afa96c8c68c50c32e3216f019ed9cab0edffb888/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c280103457863390f266a3ab46878b4d72a12dd

commit 1c280103457863390f266a3ab46878b4d72a12dd
Author: sebsg <sebsg@chromium.org>
Date: Mon Oct 02 02:30:47 2017

Update the DEPS to use the most recent libaddressinput version.

Bug:  752122 
Change-Id: I2cde3a7393115f780b7af3381df1c58272a8902c
Reviewed-on: https://chromium-review.googlesource.com/692569
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505530}
[modify] https://crrev.com/1c280103457863390f266a3ab46878b4d72a12dd/DEPS
[modify] https://crrev.com/1c280103457863390f266a3ab46878b4d72a12dd/components/autofill/core/browser/region_data_loader_impl.h
[modify] https://crrev.com/1c280103457863390f266a3ab46878b4d72a12dd/third_party/libaddressinput/BUILD.gn

Sign in to add a comment