Is this feature code complete? And ready for manual testing if needed?

Please note Feature Freeze for M62 is on Aug 18th. We're expecting feature to be complete and high level test sign off latest by August 18th. Thank you

No, this is not going to make it for 62. Re-labeling.

Flipping the a11y bit, though we still have some remaining issues the team is going to address for 64. Please see the blocking review for reference. 

We're already past M63 feature freeze and branch point, and launch-status is not set to a review state. Thus, moving this fully to M64.

When feature is ready for testing in M64, please fill out the test survey at go/chrome-test-questions. 

Please let me know if there is any concern here. Thank you.

M64 FF has passed and we're not completely done, so moving Stable target to M65. We might still want to experiment on Beta earlier than that.

Is the feature code complete and ready for testing?

Reminder that feature freeze for M65 is this Friday, 1/5.  Please change the Launch-Status to a review state and fill out the test survey at http://go/chrome-test-questions by then if you're still targeting M65.

Test questions:

1. Does the feature need manual testing? Yes
2. Feature implementation status: Chrome code is feature-complete. Simple and animated Doodles are working (and have been for a couple milestones). Interactive Doodles will work, but not until some changes in Google have become visible; no work (other than bug fixes) is expected on the Chrome side.
3. Link to Design Doc: https://docs.google.com/document/d/1qqMChnFGGKhr4qRGFVP_8qHN_MgNjs82OFBaC9jp4MY
4. Link to Test Plan: https://docs.google.com/document/d/1qqMChnFGGKhr4qRGFVP_8qHN_MgNjs82OFBaC9jp4MY#heading=h.sclvnhtryphy
5. Are there any special points of interest from a testing perspective? New Doodles are coming out all the time, and sometimes they introduce new complications. On days when there is a Google Doodle, it would be useful to check back to see if the local NTP handles it correctly.
6. Link to demos (if any): N/A
7. Targeted Platforms: Desktop (Windows, Mac, Linux, ChromeOS)
8. Is the work flow same as desktop and Mobile? N/A

9. What's automated?  Browser tests: https://cs.chromium.org/?q=LocalNTPDoodleTest. These tests cover simple and animated Doodles, but don't adequately cover interactives yet.
10. What’s not automated that needs manual testing? Interaction with interactive Doodles.
11. List reasons for still needing manual testing: These are hosted on google.com, so automated testing can't cover them.

12. What is the crbug label/component for the feature? UI>Browser>NewTabPage
13. Are there any other team members or mailing lists that should be notified if issues are found? No.

14. Is there a mechanism to turn off the feature if it breaks product functionality or performance? Yes, Finch.
15. List the names of the finch studies and the experiment groups if any. What % rollout are you requesting for each group.
DoodlesOnLocalNtp: 1% then 100%, as standard for a new feature.
16. How are you monitoring the stability of the experiment groups? UMA

17. Any performance impact? Did the feature get tested on perf waterfall? None expected; metrics for the local NTP look good so far.

Adding privacy review bug issue 799899 as a label to the launch bug  issue 752119 . This is an automated message.

Tested this feature Debian OS as per provided test plan in comment #14 and the feature is working expected.

Will test the behavior in remaining OS and update the behavior later

Tested this feature on Windows 10, Mac 10.13.2, Debian Rodete with chrome #66.0.3334.0 and on ChromeOS_Reks/10351.0.0 with chrome #66.0.3329.0, as per provided test plan in comment #14.

Observed the feature is working as expected.

Attaching the screen-casts for reference

sfiera@ Could you please look into and let us know your observations on test coverage

Note: Tested this feature for flag #use-ddljson-api with values 0,1 

Deleted: 752119- Static Doodle.mp4 809 KB

	752119- Static Doodle.mp4 809 KB View Download

Deleted: 752119- Animated Doodle.mp4 1.5 MB

	752119- Animated Doodle.mp4 1.5 MB View Download

Deleted: 752119- Themed NTP, no Doodle.mp4 2.6 MB

	752119- Themed NTP, no Doodle.mp4 2.6 MB View Download

Deleted: 752119- Themed NTP, Doodle.mp4 2.1 MB

	752119- Themed NTP, Doodle.mp4 2.1 MB View Download

Gentle Remainder:

sfiera@ Could you please respond to comment #21

Thanks, kkaluri! Those look correct.

We need Doodles 2, 3, and 4 to work before launching. But, there’s no need to test them right now: they don’t work, and we know that already :) Unfortunately, it’s not clear now when (or if) we’ll fix them and proceed.

(treib@, did you see that at 0:28 of “Themed, No Doodle”?)

Re flash in "Themed, No Doodle": That's expected. It happens when a theme is installed while an NTP is already open. Then the theme only gets applied to that NTP once the tab becomes active again. It's a rare case, and IMO it's fine. Anyway there's not much we can do about it I think.

Resetting Launch-Status since we're not currently looking for any further reviews.

Thanks for the update, please let us know if any further testing is required.

sfiera@/treib@ Could you please review test cases and let us know your observations/suggestions regarding the test coverage of this feature.

Test Cases: https://docs.google.com/spreadsheets/d/1V0l7Njc2IVU_Wp9pMwgP4dnjnprAnJEj1-PkkozuJVQ/edit#gid=145479572

Note : Could you please fill the "Automation Coverage" column in the test case sheets.

Thanks, the test cases look good to me!

What exactly is required for the "Automation Coverage" column? We do have coverage [1] so I just put in "Yes", is that sufficient?

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc?rcl=0f4916f6c03d72d91e1023aeb52eb39e8ed874e4&l=81

Thanks for reviewing the testcases.

We would like to map the manual tests with available automation coverage.It would be great if you could provide "Yes/No" all the cases as well as the link to the tests.

All tests are performed and approving from test team.

I filled the column with specific tests. Turns out we don't have tests yet for the Doodle behavior with themes, but everything else is covered.

M65 Stable launch is coming soon, pls have Legal, Security and UI reviews completed ASAP. Thank you.

Plans have changed, and this is not going to stable right now.

Updating PM ownership.

(not working on client-side Chrome any more)

Removing launch targets given that we're way too late for 64/65.  Please re-apply when you have a schedule.

Greetings, launch team!

Our new launch process (which will go into effect soon, likely next week) uses the Rollout-Type field to indicate the mechanism you will use to deploy your feature to users.  The release team will be following up aggressively on launches that are enabled by default that have not completed the required approvals on schedule (since once the code has shipped, the feature is enabled for all users).

We have not tracked rollout types before, so as part of our transition to the new process we are adding Rollout-Type-TBD to all open launch bugs.  Please update the Rollout-Type label on this launch bug ASAP based on the guidlines available here: https://docs.google.com/document/d/1hJ1U8-7DNa7lGfTJWRgSgqQyNnOFO4Ks5Czr1-3--8I/edit?ts=5af2c2ec#bookmark=id.maqw8ob21w29

If you do not update your launch's Rollout-Type, we will assume it is shipping by default and punt it more aggressively than we would for a Finch rollout.

If this launch is no longer active, please mark it as Fixed (if launched) or WontFix (if you do not plan to launch).  Please also verify your launch targets are still accurate, and update them if necessary.

More details about the updated launch process are available here: https://groups.google.com/a/google.com/d/msg/chrome-team/QZ6xI26HUJs/H6V0NirqAAAJ.  Please reach out to amineer@ with any questions or concerns; otherwise, thanks so much for your help!

Converting cross-functional bits to new bit states described in new launch process (https://docs.google.com/document/d/1hJ1U8-7DNa7lGfTJWRgSgqQyNnOFO4Ks5Czr1-3--8I/edit?usp=sharing).  Ping amineer@ with any questions.

Setting default state for new Launch-Exp-Leadership field per updates to go/newChromeFeature.  Ping amineer@ with questions.

Setting default state for new Launch-Leadership field per updates to go/newChromeFeature.  Ping amineer@ with questions.

This launch bug has not been modified in the last 90 days and has no milestone label. Please take a look and add appropriate milestone label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Setting this to for the UI bit since there is no new UI.

Setting this to N/A for the UI bit since there is no new UI.