New issue
Advanced search Search tips

Issue 752084 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

IsAutoReloadEnabled() should be removed from experimental settings.

Project Member Reported by noyau@chromium.org, Aug 3 2017 
This file is being deprecated, feature should use base::Feature instead.

It appear that this feature is turned on on all platforms but iOS
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00987a165052cb52688e4632b19f239bfc77a35a

commit 00987a165052cb52688e4632b19f239bfc77a35a
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Sep 07 16:54:02 2017

Remove AutoReloadBridge and AutoReloadController.

Code is always disabled, so remove it as it is now dead code.

Bug:  752084 
Change-Id: I011cd99b494198273c869eff35a9d37b9f59f501
Reviewed-on: https://chromium-review.googlesource.com/643186
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500323}
[modify] https://crrev.com/00987a165052cb52688e4632b19f239bfc77a35a/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/00987a165052cb52688e4632b19f239bfc77a35a/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/00987a165052cb52688e4632b19f239bfc77a35a/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/00987a165052cb52688e4632b19f239bfc77a35a/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/00987a165052cb52688e4632b19f239bfc77a35a/ios/chrome/browser/web/BUILD.gn
[delete] https://crrev.com/64fcd6872a562cbfeaab6d4269a17a5c816dbbb5/ios/chrome/browser/web/auto_reload_bridge.h
[delete] https://crrev.com/64fcd6872a562cbfeaab6d4269a17a5c816dbbb5/ios/chrome/browser/web/auto_reload_bridge.mm
[delete] https://crrev.com/64fcd6872a562cbfeaab6d4269a17a5c816dbbb5/ios/chrome/browser/web/auto_reload_controller.h
[delete] https://crrev.com/64fcd6872a562cbfeaab6d4269a17a5c816dbbb5/ios/chrome/browser/web/auto_reload_controller.mm
[delete] https://crrev.com/64fcd6872a562cbfeaab6d4269a17a5c816dbbb5/ios/chrome/browser/web/auto_reload_controller_unittest.mm

Comment 2 by sdefresne@chromium.org, Sep 7 2017

Status: Fixed (was: Assigned)

Comment 3 by sdefresne@chromium.org, Sep 7 2017

Labels: OS-iOS
►

Sign in to add a comment