New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752083 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 755973



Sign in to add a comment

chromium.webrtc.fyi bots should be component builds

Project Member Reported by mbonadei@chromium.org, Aug 3 2017

Issue description

In order to catch breakages before we roll WebRTC into Chromium we should set the build argument is_component_build to true.

Today all our chromium.webrtc.fyi bots build with is_component_build=false while Chromium trybots build with is_component_build=true.

Because of this we were not able to spot two errors until we tried to roll:
https://chromium-review.googlesource.com/c/592088
https://chromium-review.googlesource.com/c/587688
 
Owner: kjellander@chromium.org
Status: Assigned (was: Untriaged)
In general, is_component_build=true is only set on debug bots in Chromium. 
See e.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/525254 it has it to false.

See https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=d17af2013f9588c212c613e84c5dd312d44ef1d1&l=1929 and find references to 'shared' in the file to see which bots are using it.

That said, it's probably a good idea to have at least a builder for Debug for Windows, Mac and Linux. If we decide to do so, I suggest we also get one new VM for each, to avoid slowing down the throughput of the testers (which are important for short blamelists).

I can own this since Edward is soon going OOO and Mirko has a full plate already.
Thanks for the explanation.

Yes, it seems a good idea to have at least on builder for each OS.

Thanks for taking care of this.
Blockedon: 755973
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17222af1fd3b7832e43cfd547507c5cc667b0fa0

commit 17222af1fd3b7832e43cfd547507c5cc667b0fa0
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Thu Aug 17 10:57:24 2017

MB: Add Debug builders to chromium.webrtc.fyi

This will make it possible to catch more errors before trying to
roll WebRTC into Chromium.

Remove usage of outdated trybot configs and align with regular
Chromium builders in the Mac, Win and Linux waterfalls.

BUG= 752083 
NOTRY=True

Change-Id: I508ca09d08803adb38e5e7888a4f3206029578f9
Reviewed-on: https://chromium-review.googlesource.com/616284
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495133}
[modify] https://crrev.com/17222af1fd3b7832e43cfd547507c5cc667b0fa0/tools/mb/mb_config.pyl

Status: Started (was: Assigned)
Status: Fixed (was: Started)
We now have the new bots and they are working as intended (i.e. building with is_component_build=true).

Sign in to add a comment