chromium.webrtc.fyi bots should be component builds |
||||
Issue descriptionIn order to catch breakages before we roll WebRTC into Chromium we should set the build argument is_component_build to true. Today all our chromium.webrtc.fyi bots build with is_component_build=false while Chromium trybots build with is_component_build=true. Because of this we were not able to spot two errors until we tried to roll: https://chromium-review.googlesource.com/c/592088 https://chromium-review.googlesource.com/c/587688
,
Aug 16 2017
Thanks for the explanation. Yes, it seems a good idea to have at least on builder for each OS. Thanks for taking care of this.
,
Aug 16 2017
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17222af1fd3b7832e43cfd547507c5cc667b0fa0 commit 17222af1fd3b7832e43cfd547507c5cc667b0fa0 Author: Henrik Kjellander <kjellander@chromium.org> Date: Thu Aug 17 10:57:24 2017 MB: Add Debug builders to chromium.webrtc.fyi This will make it possible to catch more errors before trying to roll WebRTC into Chromium. Remove usage of outdated trybot configs and align with regular Chromium builders in the Mac, Win and Linux waterfalls. BUG= 752083 NOTRY=True Change-Id: I508ca09d08803adb38e5e7888a4f3206029578f9 Reviewed-on: https://chromium-review.googlesource.com/616284 Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Cr-Commit-Position: refs/heads/master@{#495133} [modify] https://crrev.com/17222af1fd3b7832e43cfd547507c5cc667b0fa0/tools/mb/mb_config.pyl
,
Aug 17 2017
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/75e24d6c5de9153dfe7cdf9e45ae15f920c1ba74 commit 75e24d6c5de9153dfe7cdf9e45ae15f920c1ba74 Author: Henrik Kjellander <kjellander@chromium.org> Date: Thu Aug 17 13:34:20 2017 Add Debug builders to chromium.webrtc.fyi This will make it possible to catch more errors before trying to roll WebRTC into Chromium. This depends on MB changes in https://chromium-review.googlesource.com/c/616284 BUG= 752083 , 755973 Change-Id: If91035aaa07cf7447dd5d09f8b81048c041a793e Reviewed-on: https://chromium-review.googlesource.com/616736 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org> [modify] https://crrev.com/75e24d6c5de9153dfe7cdf9e45ae15f920c1ba74/masters/master.chromium.webrtc/slaves.cfg [modify] https://crrev.com/75e24d6c5de9153dfe7cdf9e45ae15f920c1ba74/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py [modify] https://crrev.com/75e24d6c5de9153dfe7cdf9e45ae15f920c1ba74/masters/master.chromium.webrtc.fyi/master_builders_cfg.py [modify] https://crrev.com/75e24d6c5de9153dfe7cdf9e45ae15f920c1ba74/masters/master.chromium.webrtc.fyi/slaves.cfg
,
Aug 17 2017
We now have the new bots and they are working as intended (i.e. building with is_component_build=true). |
||||
►
Sign in to add a comment |
||||
Comment 1 by kjellander@chromium.org
, Aug 16 2017Status: Assigned (was: Untriaged)