New issue
Advanced search Search tips

Issue 752077 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Remove IsPasswordGenerationEnabled() experimental flag.

Project Member Reported by noyau@chromium.org, Aug 3 2017

Issue description

All flags should migrate to base::Feature with their UI in chrome_flags. The function IsPasswordGenerationEnabled() should be removed.

See go/feature-flags-on-ios for details.
 

Comment 1 by noyau@chromium.org, Aug 3 2017

Owner: dvadym@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by noyau@chromium.org, Aug 3 2017

Summary: Remove IsPasswordGenerationEnabled() experimental flag. (was: Remove IsPasswordGenerationEnabled(0 experimental flag.)

Comment 3 by noyau@chromium.org, Aug 3 2017

Just noticed that there is another flag that I also have to remove: UseOnlyLocalHeuristicsForPasswordGeneration()

The component code uses base::Feature already, as well as command line flags. Why were those duplicated for iOS? Can't they just be reused?
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d17af2013f9588c212c613e84c5dd312d44ef1d1

commit d17af2013f9588c212c613e84c5dd312d44ef1d1
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Wed Aug 16 13:30:27 2017

Remove using local heuristics for generation.

It was never used even on Desktop and proposing generation without server-side is bad idea. Let's clean it.

Bug:  752077 
Change-Id: I77416854ab693f745ffdca0eb1e97740c90947c1
Reviewed-on: https://chromium-review.googlesource.com/608167
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494758}
[modify] https://crrev.com/d17af2013f9588c212c613e84c5dd312d44ef1d1/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/d17af2013f9588c212c613e84c5dd312d44ef1d1/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/d17af2013f9588c212c613e84c5dd312d44ef1d1/ios/chrome/browser/passwords/password_generation_agent.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf9011e0b0b616247946b47875e491d75dca190d

commit cf9011e0b0b616247946b47875e491d75dca190d
Author: vasilii <vasilii@chromium.org>
Date: Tue Nov 07 11:37:14 2017

Drop PasswordGenerationAgent on iOS.

The class wasn't maintained because password generation isn't supported yet on iOS.

Bug:  752077 , 700010 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2f05bc83d9a9c076daa046e9b2df37250fe5db6a
Reviewed-on: https://chromium-review.googlesource.com/755595
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514448}
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_controller.mm
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_generation_agent.h
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_generation_agent.mm
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_generation_agent_unittest.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_tab_helper.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_tab_helper.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/tabs/tab_helper_util.mm

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71552dd95119459b8d39effe98e57486b2c7b005

commit 71552dd95119459b8d39effe98e57486b2c7b005
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Mon Nov 13 19:36:12 2017

Remove Password Generation leftovers on IOS.

On CL https://chromium-review.googlesource.com/c/chromium/src/+/755595
Password Generation on IOS was removed. This CL removes leftovers.

Bug:  752077 , 700010 ,782224
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idbd84d45874a877bdc0ab81299123600442f2c98
Reviewed-on: https://chromium-review.googlesource.com/758836
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516006}
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/js_password_manager.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/js_password_manager.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller_js_unittest.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller_unittest.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_edit_view.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_edit_view.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_offer_view.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_offer_view.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_delegate.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view_controller.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_generation_utils.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_generation_utils.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_tab_helper.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_tab_helper.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/passwords_ui_delegate.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/passwords_ui_delegate_impl.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/passwords_ui_delegate_impl.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/resources/password_controller.js
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/tabs/BUILD.gn
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/tabs/tab_helper_util.mm

Sign in to add a comment