Regression : Unable to reload PDF file after terminating 'Plugin : Chrome PDF Plugin' process multiple times.
Reported by
avsha...@etouch.net,
Aug 3 2017
|
|||||
Issue descriptionChrome version : 61.0.3163.29 (Official Build) b1e8882790982afc7ba75a4034eb154d9594d01a-refs/branch-heads/3163@{#245} 32/64 bit OS : Windows (7,8,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.3, 10.12.5) Test URL : http://westgov.org/images/files/pdf-test.pdf What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Hit 'Shift + Esc' keys to open 'Chrome Task Manager'. 3. Select 'Plugin : Chrome PDF Plugin' process, end the process (Plugin crashes) and reload the PDF page. 4. Repeat step 3 two more times and observe the PDF file. Actual Result : PDF file shows an error message and does not reload after terminating 'Plugin : Chrome PDF Plugin' process multiple times. Expected Result : Should be able to reload PDF file even after terminating 'Plugin : Chrome PDF Plugin' process multiple times. This is a regression issue broken in ‘M-61’, will soon update Manual Regression range. Good build : 61.0.3125.0 Bad build : 61.0.3126.0 Note : Issue can be reproduced on any PDF file.
,
Aug 14 2017
So, this happened because after I renamed the PDF plugin, it's not considered fully_trusted anymore, just the PDF extension is considered fully_trusted, so the PDF plugin is now subject to the check in PluginServiceImpl::IsPluginUnstable. If needed, we can easily add the PDF plugin to the fully trusted list. I'm not really sure if the PDF plugin should be fully trusted, and would like hear the opinion of bauerb@ (OWNER of plugins_*.json) and thestig@ (OWNER of PDF). Thoughts?
,
Aug 17 2017
If the plugin was had fully_trusted status before, why don't we just give it that status back? I see it gets SECURITY_STATUS_FULLY_TRUSTED which is used in only one place to indicate the plugin is always allowed. Which is fine for the PDF Viewer since it's as up to date as the browser and its native code lives within the chrome binary.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8088c308db8b7638082bedd7f31a117b444ce31 commit e8088c308db8b7638082bedd7f31a117b444ce31 Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Fri Aug 18 21:43:08 2017 Add pdf plugin to fully_trusted plugins list. This is necessary because https://chromium-review.googlesource.com/c/518224 split the PDF extension plugin and the PPAPI PDF plugin. Bug: 752074 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6ca5b4c0804e28577739216172561788854d3d82 Reviewed-on: https://chromium-review.googlesource.com/621512 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#495697} [modify] https://crrev.com/e8088c308db8b7638082bedd7f31a117b444ce31/chrome/browser/resources/plugin_metadata/plugins_chromeos.json [modify] https://crrev.com/e8088c308db8b7638082bedd7f31a117b444ce31/chrome/browser/resources/plugin_metadata/plugins_linux.json [modify] https://crrev.com/e8088c308db8b7638082bedd7f31a117b444ce31/chrome/browser/resources/plugin_metadata/plugins_mac.json [modify] https://crrev.com/e8088c308db8b7638082bedd7f31a117b444ce31/chrome/browser/resources/plugin_metadata/plugins_win.json
,
Aug 21 2017
Update : Retested above issue in latest chrome canary #62.0.3192.0 on Windows(7,8,10), Linux(14.04 LTS)& Mac(10.11.6, 10.12.3, 10.12.5) OS and issue is not reproducible. Issue is fixed now and able to reload PDF file even after terminating 'Chrome PDF Plugin' multiple times. Kindly review an attached screen cast. Thank you!
,
Aug 21 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kkaluri@chromium.org
, Aug 3 2017Labels: hasbisect-per-revision
Owner: lfg@chromium.org
Status: Assigned (was: Unconfirmed)