In print preview, error message is seen even for a default scaling value.
Reported by
avsha...@etouch.net,
Aug 3 2017
|
||||
Issue descriptionChrome Version : 61.0.3163.29 (Official Build) b1e8882790982afc7ba75a4034eb154d9594d01a-refs/branch-heads/3163@{#245} 32/64-bit OS: Windows(7,8,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.3, 10.12.5) What steps will reproduce the problem? 1. Launch chrome, open NTP and hit 'Ctrl + P' keys to open print preview. 2. Click on 'More settings' and in 'Scale' text field enter "666" such that it shows an error message below the text field. 3. Now clear the scaling field and click outside a text field. 4. Observe the scaling field and error message. Actual Result : Error message is seen even for a default scaling value. Expected Result : Error message should vanish once the scaling value is restored back to 100. This is a Non-Regression issue seen from M-56 build #56.0.2902.0, as the 'Scale' option was introduced in 'Print Preview' from this build. Note : Sometimes need to repeat steps twice in order to reproduce an issue.
,
Aug 10 2017
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d02c4182a2dba46e927fcae48619008f46c2c0d6 commit d02c4182a2dba46e927fcae48619008f46c2c0d6 Author: rbpotter <rbpotter@chromium.org> Date: Fri Aug 11 21:02:35 2017 Print Preview: Remove scale error message when value resets to default Scale resets to default (fit to page scaling if fit to page is selected and 100 otherwise) when focus leaves the field when it is empty. Ensure the error message, if one exists, is hidden in this case. Also ensure the error message is hidden if the user changes the scaling value to a valid one by checking or unchecking "Fit to Page". Bug: 752044 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I579ea3db0b1cdf6405acd36f40454bfec4a2f6f6 Reviewed-on: https://chromium-review.googlesource.com/611562 Reviewed-by: Demetrios Papadopoulos (OOO till Sept 11th) <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#493852} [modify] https://crrev.com/d02c4182a2dba46e927fcae48619008f46c2c0d6/chrome/browser/resources/print_preview/settings/scaling_settings.js
,
Aug 14 2017
Verified this issue on Windows 10, Ubuntu 14.04 & Mac 10.12.6 with Chrome #62.0.3185.0 and didn't observe any error message is seen for a default scaling value.Hence adding a TE-Verified labels. Attaching a screen-cast for reference.
,
Aug 14 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nyerramilli@chromium.org
, Aug 3 2017