New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752037 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ContentSuggestions section titles are not shown

Project Member Reported by gambard@chromium.org, Aug 3 2017

Issue description

What steps will reproduce the problem?
(1) Open NTP with Reading List articles
(2) The section titles are shown during the appearance of the NTP

What is the expected result?
The section titles should still be displayed

What happens instead?
The section titles disappear
 
Labels: OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0949160e1a76623658d4bba4e8997b92066fa2d3

commit 0949160e1a76623658d4bba4e8997b92066fa2d3
Author: gambard <gambard@chromium.org>
Date: Thu Aug 03 11:25:56 2017

Reset data holder for section title on reload

The section identifiers of the added sections part of ContentSuggestions
need to be reset when all the data concerning the added items is reset.

Bug:  752037 
Change-Id: Ic37871e9f8f8bb3e43bc63af03a47d1756902fbe
Reviewed-on: https://chromium-review.googlesource.com/600048
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491698}
[modify] https://crrev.com/0949160e1a76623658d4bba4e8997b92066fa2d3/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on :

Application Version: 62.0.3179.0 canary
Devices: iPadMini 2, iPhone 7 Plus, iPhone5, 
iOS Version: 11.0 beta 5, 10.3.3, 9.3.5

Issue is fixed. Content Suggestions and Reading list section titles are shown in NTP when a user signed in to chrome has reading list entries. Please see the screenshot attached.

Hence marking the bug as 'verified'


 
ContentSug_ReadingList_SectionTitles.PNG
388 KB View Download

Sign in to add a comment