New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752035 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression : 'More..' Tool tip doesn't get vanished on clicking Enter when focus is on Three dot menu in FilesApp

Project Member Reported by mmanchala@chromium.org, Aug 3 2017

Issue description

Chrome Version: 61.0.3163.30/9765.16.0 dev channel Daisy,Reks,Minnie,Jerry & Quawks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Download image
(2)Go to Files App-> select image so that 'Cancel selection','Open','Delete' ,'Three dot menu' options are seen
(3)Now press 'Tab' button until focus is on Three dot menu('More..' tool tip is seen) -> Click on enter so that Menu is seen -> Now observe 'More..' Tool tip is still seen(Please refer Video and screenshot)

Expected: 'More..' Tool tip should get vanished on clicking Enter when  focus is on Three dot menu
Actual: Instead Tooltip remains on Menu

This is Non-Regression Issue seen as 'More..' tool tip for three dot menu is introduced from 62.0.3164.0

@fukino: Please confirm the issue

Note: Issue is seen on Latest M-62 also
 
Actual_Tooltip.webm
622 KB View Download
Actual_Tooltip.jpg
61.7 KB View Download
Expected_Tooltip.webm
354 KB View Download
Owner: yamaguchi@chromium.org
I could reproduce this.
Assigned to me as I made the change add the button.
Labels: -M-62 M-64
Status: WontFix (was: Assigned)
Not reproduced on 65.0.3286.0.
Marking as Won't Fix (obsolete) for now, but we'd need to find the exact change that caused this for preventing future regression.

The FilesTooltip class sets hiding timer when opening the menu, by the blur event.
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/files_tooltip.js?q=file:files_tooltip.js+onblur&sq=package:chromium&l=221
A possible hypothesis is that the event had not been not sent to it by some reason.

This issue may has same origin as  Issue 769593 .
Cc: fukino@chromium.org
Status: Assigned (was: WontFix)
Reopening this issue as able to reproduce this on M-68 dev 68.0.3440.15/10718.13.0 Kip device

Thanks..!!
Labels: -Pri-2 -M-64 CrOSFilesCategory-UI Pri-3
Owner: ----
Status: Available (was: Assigned)
Labels: Files-Fixit-2018
Owner: adanilo@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae45f5fcf365b42334971b3a4b3cd47fbcefebb

commit dae45f5fcf365b42334971b3a4b3cd47fbcefebb
Author: Alex Danilo <adanilo@chromium.org>
Date: Thu Nov 22 07:19:55 2018

Hide tooltip when activating selection menu

Selecting a file, then tabbing to the selection menu button
should hide the tooltip if the menu is activated from the
keyboard. This change explicitly hides the tooltip on menu
activation.

      behaviour is correct on desktop and real device.

Bug:  752035 
Test: Ran all FilesApp browser tests. Manually verified
Change-Id: I8c13364748773da2521129e95d7edb29c4032edd
Reviewed-on: https://chromium-review.googlesource.com/c/1347958
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610328}
[modify] https://crrev.com/dae45f5fcf365b42334971b3a4b3cd47fbcefebb/ui/file_manager/file_manager/foreground/js/selection_menu_controller.js

Status: Fixed (was: Started)

Sign in to add a comment