New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752034 link

Starred by 1 user
Status: Archived
Owner:
steve...@chromium.org
Closed: Aug 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ keta...@chromium.org
█ reve...@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Focus doesn't traverse in 'Set your profile picture' screen on using arrow keys.

Project Member Reported by jbanavatu@chromium.org, Aug 3 2017 
Chrome Version: 62.0.3174.0/9803.0.0 dev channel Daisy,Minnie,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build >> Give valid email and password in sign in screen and click on next button
(2)Now in 'Set your profile picture' screen, hit Up/Down/Right/left key and Observe focus. (Please refer video)

Expected: Focus should traverse to  next profile pic in 'Set your profile picture' screen on using arrow keys.
Actual: Instead Focus does not traverse.

This is regression issue as same is working fine in 60.0.3112.80/9592.71.0 Beta channel Daisy.

Note:
1. Issue is also seen Latest M-61.0.3163.30/9765.16.0 dev
2. Issue is not applicable to Linux and Windows OS
3. Issue is not seen in chrome://settings/changePicture page both in M-61 and M-62.

Attaching screen-cast for reference.
Expected.mp4
11.6 MB View Download
Actual.mp4
13.0 MB View Download

Comment 1 by abodenha@chromium.org, Aug 3 2017

Components: -UI UI>Settings
Owner: steve...@chromium.org

Comment 2 by steve...@chromium.org, Aug 3 2017

Labels: -Pri-1 -M-62 M-61 Pri-2
Status: Assigned (was: Untriaged)

Comment 3 by steve...@chromium.org, Aug 15 2017

Cc: reve...@chromium.org
Status: Started (was: Assigned)
I also noticed that we do not automatically scroll the image list when using keyboard navigation; I'll see if I can easily fix that also.

Comment 5 by steve...@chromium.org, Aug 16 2017

Status: Fixed (was: Started)

Comment 6 by steve...@chromium.org, Aug 16 2017

Labels: Merge-Request-61

Comment 7 by keta...@chromium.org, Aug 16 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 21 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/586aad27408b3243ada75f7f640269d7ec2416b1

commit 586aad27408b3243ada75f7f640269d7ec2416b1
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Aug 21 18:41:54 2017

WebUI: Change Picture: Focus list in oobe and scroll to selected

TBR=stevenjb@chromium.org

(cherry picked from commit 58853d1918fdf337dde1fd457e89856712ebbc9a)

Bug:  752034 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie28fbb60cb547e98e49ddf12c4be3807419e5821
Reviewed-on: https://chromium-review.googlesource.com/615746
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494638}
Reviewed-on: https://chromium-review.googlesource.com/624380
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#706}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/586aad27408b3243ada75f7f640269d7ec2416b1/chrome/browser/resources/chromeos/login/oobe_change_picture.html
[modify] https://crrev.com/586aad27408b3243ada75f7f640269d7ec2416b1/chrome/browser/resources/chromeos/login/oobe_change_picture.js
[modify] https://crrev.com/586aad27408b3243ada75f7f640269d7ec2416b1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
[modify] https://crrev.com/586aad27408b3243ada75f7f640269d7ec2416b1/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html
[modify] https://crrev.com/586aad27408b3243ada75f7f640269d7ec2416b1/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment