New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752002 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Chrome
Pri: 2
Type: Feature



Sign in to add a comment

[CrOS] Chrome Internal Page for system monitoring

Project Member Reported by chungsheng@google.com, Aug 3 2017

Issue description

Feature description:
A new Chrome Internal Page chrome://sys-internals which can monitor CPU usage, memory and zRam(ChromeOS) statistic.
Go to chrome://flags/#sys-internals to enable this feature.

Eng owner: chungsheng@google.com
Product owner: vovoy@google.com

Design doc: https://docs.google.com/a/google.com/document/d/1udK5OHQ085by9T74R2BAlOLkqyjcwBWCVKAaimPEmNc/edit?usp=sharing

This new feature will be split to three patch.
Backend: https://chromium-review.googlesource.com/c/chromium/src/+/625499
Line chart lib: https://chromium-review.googlesource.com/c/chromium/src/+/649390
Frontend: https://chromium-review.googlesource.com/c/chromium/src/+/659700
 

Comment 1 by vovoy@chromium.org, Aug 7 2017

Cc: -bccheng@google.com bccheng@chromium.org
Components: OS>Performance
Labels: OS-Chrome
Labels: -OS-Chrome
Description: Show this description

Comment 3 by vovoy@chromium.org, Aug 22 2017

Cc: brettw@chromium.org deanliao@chromium.org
Components: -OS>Performance UI>Browser>WebUI
Labels: Performance
Labels: -Performance Performance-Browser

Comment 6 by vovoy@chromium.org, Aug 28 2017

Cc: calamity@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e

commit 468b0b35bffd3dc6f5a49e93aa036d5691c2b31e
Author: Chung-Sheng Wu <chungsheng@google.com>
Date: Fri Sep 01 14:41:57 2017

[CrOS] Show system information via Chrome Internal Page

Shows information like CPU usage, Memory status, Zram status.

This patch adds the implementation for the Internal Page backend.
Get system information via Chrome base api, and pass the data to
frontend by calling Javascript function.

Bug:  752002 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I76c863176270ee61268d22c880b74dafb0958b10
Reviewed-on: https://chromium-review.googlesource.com/625499
Commit-Queue: Zhong-sheng Wu <chungsheng@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499191}
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/about_flags.cc
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/browser_resources.grd
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/flag_descriptions.h
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/resources/sys_internals/index.css
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/resources/sys_internals/index.html
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/resources/sys_internals/index.js
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/ui/webui/sys_internals/sys_internals_message_handler.cc
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/ui/webui/sys_internals/sys_internals_message_handler.h
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/ui/webui/sys_internals/sys_internals_ui.cc
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/browser/ui/webui/sys_internals/sys_internals_ui.h
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/common/chrome_features.cc
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/common/chrome_features.h
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/common/url_constants.cc
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/common/url_constants.h
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/chrome/test/data/webui/sys_internals/sys_internals_browsertest.js
[modify] https://crrev.com/468b0b35bffd3dc6f5a49e93aa036d5691c2b31e/tools/metrics/histograms/enums.xml

Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Labels: OS-Chrome
Summary: [CrOS] Chrome Internal Page for system monitoring (was: Chrome Internal Page for system monitoring)
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/124d0939677878ff9f5626e07396457fc36a156d

commit 124d0939677878ff9f5626e07396457fc36a156d
Author: Chung-Sheng Wu <chungsheng@google.com>
Date: Mon Sep 11 08:07:09 2017

[CrOS] SysInternals: Line chart library

Shows information like CPU usage, Memory status, Zram status.

This patch adds the implementation for the Internal Page line chart
library. The line chart library maintain a HTML canvas and show the
data with a scrollable line chart.


Bug:  752002 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifd7a1aadb95693dce2c88202486b951e94d86513
Reviewed-on: https://chromium-review.googlesource.com/649390
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Zhong-sheng Wu <chungsheng@google.com>
Cr-Commit-Position: refs/heads/master@{#500858}
[modify] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/browser_resources.grd
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/compiled_resources2.gyp
[modify] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/index.html
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/README.md
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/compiled_resources2.gyp
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/constants.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/data_series.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/index.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/line_chart.css
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/line_chart.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/menu.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/scrollbar.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/sub_chart.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/resources/sys_internals/line_chart/unit_label.js
[modify] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/browser/ui/webui/sys_internals/sys_internals_ui.cc
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/api_test.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/line_chart/data_series_test.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/line_chart/line_chart_test.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/line_chart/menu_test.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/line_chart/scrollbar_test.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/line_chart/sub_chart_test.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/line_chart/unit_label_test.js
[modify] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/sys_internals_browsertest.js
[add] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/chrome/test/data/webui/sys_internals/test_util.js
[modify] https://crrev.com/124d0939677878ff9f5626e07396457fc36a156d/third_party/closure_compiler/compiled_resources2.gyp

Description: Show this description

Comment 15 Deleted

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d8065f713f5a157af82f1b9733a9f71c15f0937

commit 5d8065f713f5a157af82f1b9733a9f71c15f0937
Author: Chung-Sheng Wu <chungsheng@google.com>
Date: Fri Sep 15 04:44:39 2017

[CrOS] SysInternals: Frontend

Shows information like CPU usage, Memory status, Zram status.

This patch adds the implementation for the chrome://sys-internals page frontend.
It gets the data from backend and then uses the LineChart library to show the data.

Bug:  752002 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I41fd29135b2b40050713cf40050b95b6f7734fbf
Reviewed-on: https://chromium-review.googlesource.com/659700
Commit-Queue: Zhong-sheng Wu <chungsheng@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502156}
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/browser_resources.grd
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/compiled_resources2.gyp
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/constants.js
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/externs.js
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/img/cpu.svg
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/img/info.svg
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/img/memory.svg
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/img/menu.svg
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/img/zram.svg
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/index.css
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/index.html
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/index.js
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/resources/sys_internals/types.js
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/browser/ui/webui/sys_internals/sys_internals_ui.cc
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/test/data/webui/sys_internals/page_drawer_test.js
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/test/data/webui/sys_internals/page_infopage_test.js
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/test/data/webui/sys_internals/page_switch_test.js
[add] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/test/data/webui/sys_internals/page_unit_test.js
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/test/data/webui/sys_internals/sys_internals_browsertest.js
[modify] https://crrev.com/5d8065f713f5a157af82f1b9733a9f71c15f0937/chrome/test/data/webui/sys_internals/test_util.js

Description: Show this description
Description: Show this description
Description: Show this description
Status: Fixed (was: Started)

Comment 21 by cn...@chromium.org, Sep 28 2017

Description: Show this description

Comment 22 by cn...@chromium.org, Sep 28 2017

Description: Show this description

Comment 23 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 24 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment