New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751991 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

80.5% improvement in smoothness.tough_canvas_cases at 487062:487175

Project Member Reported by alexclarke@chromium.org, Aug 3 2017

Issue description

Suspiciously large improvement.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=751991

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d59e8874ec7222d271dddac660da42da19453f3e881b7bc134633f59e27941e2


Bot(s) for this bug's original alert(s):

chromium-rel-win7-x64-dual
Cc: ccameron@chromium.org
Owner: ccameron@chromium.org

=== Auto-CCing suspected CL author ccameron@chromium.org ===

Hi ccameron@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Christopher Cameron
  Commit : d4b678751117983dc92a85a3879445bd8aa33ffb
  Date   : Mon Jul 17 12:14:37 2017
  Subject: Make SkImage_Lazy cache its result from onMakeColorSpace

Bisect Details
  Configuration: win_x64_perf_bisect
  Benchmark    : smoothness.tough_canvas_cases
  Metric       : frame_times/http___ie.microsoft.com_testdrive_Performance_AsteroidBelt_Default.html
  Change       : 80.98% | 97.0884013795 -> 18.4687951699

Revision                             Result                   N
chromium@487061                      97.0884 +- 5.17675       6      good
chromium@487065                      95.4 +- 1.04781          6      good
chromium@487067                      96.8011 +- 7.60526       6      good
chromium@487068                      97.3143 +- 9.50108       6      good
chromium@487068,skia@d4b6787511      18.5074 +- 0.62694       6      bad       <--
chromium@487069                      18.3972 +- 0.538289      6      bad
chromium@487076                      18.7555 +- 0.587142      6      bad
chromium@487090                      18.2712 +- 0.822276      6      bad
chromium@487118                      18.6024 +- 0.473884      6      bad
chromium@487175                      18.4688 +- 0.663184      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...ie.microsoft.com.testdrive.Performance.AsteroidBelt.Default.html smoothness.tough_canvas_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8972297513870056992


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Untriaged)
Looks like this fixed a nasty perf regression. We can close this bug :)

Sign in to add a comment