New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751985 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 730036
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3%-27.9% regression in system_health.memory_desktop at 490746:490774

Project Member Reported by alexclarke@chromium.org, Aug 3 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=751985

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3fc37687ad186715276a5eac80fe8e9e02e76678ad9f46738373818fdaee948a


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Cc: xunji...@chromium.org
Owner: xunji...@chromium.org

=== Auto-CCing suspected CL author xunjieli@chromium.org ===

Hi xunjieli@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Helen Li
  Commit : 05ee1dbfaf0aa7c03b9ea2040f0345277042d0f1
  Date   : Mon Jul 31 13:24:01 2017
  Subject: [wpr-go] Switch system_health_desktop.json to use go

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_media/load_media_9gag
  Change       : 27.92% | 9516864.0 -> 12173886.6667

Revision             Result                   N
chromium@490745      9516864 +- 12624.7       6      good
chromium@490749      9535979 +- 89066.4       6      good
chromium@490750      9533931 +- 91344.8       6      good
chromium@490751      12187540 +- 87610.4      6      bad       <--
chromium@490753      12185492 +- 89925.6      6      bad
chromium@490760      12185492 +- 89925.6      6      bad
chromium@490774      12173887 +- 10707.2      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.9gag system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8972297638357048528


For feedback, file a bug with component Speed>Bisection
 Issue 751984  has been merged into this issue.
I presume this isn't actually a regression and we can just WontFix this.  Please confirm.
 Issue 751983  has been merged into this issue.
Mergedinto: 730036
Status: Duplicate (was: Untriaged)
I do not know why WprGo has an effect on memory allocated by CC. The jump isn't too much, and given that memory usage increased across the board, I think it's safe to say that this is a part of the change in performance characteristics from the WebPageReplay rewrite.

Sign in to add a comment